From: Lyude <cpaul@redhat.com>
To: Jani Nikula <jani.nikula@intel.com>, intel-gfx@lists.freedesktop.org
Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
Subject: Re: [PATCH] drm/i915: make skl_ddb_add_affected_planes static
Date: Tue, 04 Oct 2016 09:28:46 -0400 [thread overview]
Message-ID: <1475587726.23774.9.camel@redhat.com> (raw)
In-Reply-To: <1475573357-30562-1-git-send-email-jani.nikula@intel.com>
Reviewed-by: Lyude <cpaul@redhat.com>
On Tue, 2016-10-04 at 12:29 +0300, Jani Nikula wrote:
> Fix sparse warning:
>
> drivers/gpu/drm/i915/intel_pm.c:3970:1: warning: symbol
> 'skl_ddb_add_affected_planes' was not declared. Should it be static?
>
> Fixes: 7f60e200e254 ("drm/i915/gen9: only add the planes actually
> affected by ddb changes")
> Cc: Lyude <cpaul@redhat.com>
> Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>
> ---
>
> Please run sparse on your patches, please run sparse before you push.
> ---
> drivers/gpu/drm/i915/intel_pm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_pm.c
> b/drivers/gpu/drm/i915/intel_pm.c
> index 425544b1f733..7f1748a1e614 100644
> --- a/drivers/gpu/drm/i915/intel_pm.c
> +++ b/drivers/gpu/drm/i915/intel_pm.c
> @@ -3966,7 +3966,7 @@ pipes_modified(struct drm_atomic_state *state)
> return ret;
> }
>
> -int
> +static int
> skl_ddb_add_affected_planes(struct intel_crtc_state *cstate)
> {
> struct drm_atomic_state *state = cstate->base.state;
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2016-10-04 13:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-04 9:29 [PATCH] drm/i915: make skl_ddb_add_affected_planes static Jani Nikula
2016-10-04 10:19 ` ✗ Fi.CI.BAT: warning for " Patchwork
2016-10-04 10:26 ` [PATCH] " Joonas Lahtinen
2016-10-04 10:53 ` Jani Nikula
2016-10-04 13:28 ` Lyude [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1475587726.23774.9.camel@redhat.com \
--to=cpaul@redhat.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=paulo.r.zanoni@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.