diff for duplicates of <1475596893.2340.3.camel@perches.com> diff --git a/a/1.txt b/N1/1.txt index 4235c7d..727fe2d 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -10,13 +10,13 @@ On Tue, 2016-10-04 at 21:06 +0530, Vinod Koul wrote: > > > > diff --git a/drivers/dma/coh901318.c b/drivers/dma/coh901318.c > > > [] > > > > @@ -1353,7 +1353,7 @@ static ssize_t coh901318_debugfs_read(struct file *file, char __user *buf, -> > > > ? tmp += sprintf(tmp, "DMA -- enabled dma channels\n"); +> > > > tmp += sprintf(tmp, "DMA -- enabled dma channels\n"); > > > > -> > > > ? for (i = 0; i < U300_DMA_CHANNELS; i++) +> > > > for (i = 0; i < U300_DMA_CHANNELS; i++) > > > > - if (started_channels & (1 << i)) > > > > + if (started_channels & ((u64)1 << i)) > > > Using -> > > ? if (started_channels & (1ULL << i)) +> > > if (started_channels & (1ULL << i)) > > > would be more common. > > Even better (IMO): > > #include <linux/bitops.h> diff --git a/a/content_digest b/N1/content_digest index 2d8348a..0ee4272 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -2,10 +2,16 @@ "ref\01475172392.2027.12.camel@perches.com\0" "ref\0CACRpkdZ1gfZu=Snh9YK1X9w+ZW-zcuEFh8aojGi-LUKoyMKcCQ@mail.gmail.com\0" "ref\020161004153645.GG2467@localhost\0" - "From\0joe@perches.com (Joe Perches)\0" - "Subject\0[PATCH] dmaengine: coh901318: fix integer overflow when shifting more than 32 places\0" + "From\0Joe Perches <joe@perches.com>\0" + "Subject\0Re: [PATCH] dmaengine: coh901318: fix integer overflow when shifting more than 32 places\0" "Date\0Tue, 04 Oct 2016 09:01:33 -0700\0" - "To\0linux-arm-kernel@lists.infradead.org\0" + "To\0Vinod Koul <vinod.koul@intel.com>" + " Linus Walleij <linus.walleij@linaro.org>\0" + "Cc\0Colin King <colin.king@canonical.com>" + Dan Williams <dan.j.williams@intel.com> + linux-arm-kernel@lists.infradead.org <linux-arm-kernel@lists.infradead.org> + dmaengine@vger.kernel.org + " linux-kernel@vger.kernel.org <linux-kernel@vger.kernel.org>\0" "\00:1\0" "b\0" "On Tue, 2016-10-04 at 21:06 +0530, Vinod Koul wrote:\n" @@ -20,13 +26,13 @@ "> > > > diff --git a/drivers/dma/coh901318.c b/drivers/dma/coh901318.c\n" "> > > []\n" "> > > > @@ -1353,7 +1353,7 @@ static ssize_t coh901318_debugfs_read(struct file *file, char __user *buf,\n" - "> > > > ? tmp += sprintf(tmp, \"DMA -- enabled dma channels\\n\");\n" + "> > > > \302\240 tmp += sprintf(tmp, \"DMA -- enabled dma channels\\n\");\n" "> > > > \n" - "> > > > ? for (i = 0; i < U300_DMA_CHANNELS; i++)\n" + "> > > > \302\240 for (i = 0; i < U300_DMA_CHANNELS; i++)\n" "> > > > - if (started_channels & (1 << i))\n" "> > > > + if (started_channels & ((u64)1 << i))\n" "> > > Using\n" - "> > > ? if (started_channels & (1ULL << i))\n" + "> > > \302\240 if (started_channels & (1ULL << i))\n" "> > > would be more common.\n" "> > Even better (IMO):\n" "> > #include <linux/bitops.h>\n" @@ -40,4 +46,4 @@ "consistently in the entire file and not just this\n" instance. -5b3658c408dcc1aefddfb2c9b641cbff7242f46f0476035c447ff736dfc29abd +ac5aabbe8a6ce3c3c1526f19c2bbc300ad1abaf45a32144af186f6ea72666e27
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.