diff for duplicates of <1475652134.2070.0.camel@gmail.com> diff --git a/a/1.txt b/N1/1.txt index ae5294e..085442c 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -51,14 +51,15 @@ On Tue, 2016-10-04 at 10:23 +0200, Thomas Huth wrote: > > > + /* Sanity check for the property layout (first two bytes > > > are > > > header) */ -> > > + assert(plen >= 8 && prop->data[1] = 0 && prop->data[0] -> > > <> > > plen - 2); +> > > + assert(plen >= 8 && prop->data[1] == 0 && prop->data[0] +> > > <= +> > > plen - 2); > > Just curious as to why you're checking "prop->data[0] *<=* plen - > > 2" as -> > isn't anything other than prop->data[0] *=* plen - 2 an error in +> > isn't anything other than prop->data[0] *==* plen - 2 an error in > > the > > structure of ibm,pa-features and thus an error in the device-tree? -> QEMU currently uses prop->data[0] = plen - 2 , but looking at the +> QEMU currently uses prop->data[0] == plen - 2 , but looking at the > LoPAPR specification, it clearly defines this property as > "prop-encoded-array: One or more attribute-descriptor(s)", so there > could be two or more attributes encoded in this property. While there diff --git a/a/content_digest b/N1/content_digest index f5bbd09..8cd2204 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -3,7 +3,7 @@ "ref\0e46852e2-6a95-316d-c0d8-b2e7dd52ea13@redhat.com\0" "From\0Suraj Jitindar Singh <sjitindarsingh@gmail.com>\0" "Subject\0Re: [kvm-unit-tests PATCH v2] powerpc: Check whether TM is available before running other tests\0" - "Date\0Wed, 05 Oct 2016 07:22:14 +0000\0" + "Date\0Wed, 05 Oct 2016 18:22:14 +1100\0" "To\0Thomas Huth <thuth@redhat.com>" " kvm@vger.kernel.org\0" "Cc\0Radim Kr\304\215m\303\241\305\231 <rkrcmar@redhat.com>" @@ -65,14 +65,15 @@ "> > > +\t/* Sanity check for the property layout (first two bytes\n" "> > > are\n" "> > > header) */\n" - "> > > +\tassert(plen >= 8 && prop->data[1] = 0 && prop->data[0]\n" - "> > > <> > > plen - 2);\n" + "> > > +\tassert(plen >= 8 && prop->data[1] == 0 && prop->data[0]\n" + "> > > <=\n" + "> > > plen - 2);\n" "> > Just curious as to why you're checking \"prop->data[0] *<=* plen -\n" "> > 2\" as\n" - "> > isn't anything other than prop->data[0] *=* plen - 2 an error in\n" + "> > isn't anything other than prop->data[0] *==* plen - 2 an error in\n" "> > the\n" "> > structure of ibm,pa-features and thus an error in the device-tree?\n" - "> QEMU currently uses prop->data[0] = plen - 2 , but looking at the\n" + "> QEMU currently uses prop->data[0] == plen - 2 , but looking at the\n" "> LoPAPR specification, it clearly defines this property as\n" "> \"prop-encoded-array: One or more attribute-descriptor(s)\", so there\n" "> could be two or more attributes encoded in this property. While there\n" @@ -114,4 +115,4 @@ "> \302\240Thomas\n" > -a1b97e16bdd8bcdc8659e45671a4ff1a1a05eeace5b50e104db6c78f6b5ff2e3 +8fefb7a61d91d336cc07cbae6767cc493985aaef482bafef73937d6e05eb4866
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.