From: Johannes Berg <johannes@sipsolutions.net>
To: linux-wireless@vger.kernel.org
Cc: Michael Braun <michael-dev@fami-braun.de>
Subject: Re: [PATCH] cfg80211: let ieee80211_amsdu_to_8023s() take only 802.3 header
Date: Wed, 05 Oct 2016 15:57:17 +0200 [thread overview]
Message-ID: <1475675837.5257.1.camel@sipsolutions.net> (raw)
In-Reply-To: <1475674414-23086-1-git-send-email-johannes@sipsolutions.net> (sfid-20161005_153344_222282_258F288B)
On Wed, 2016-10-05 at 15:33 +0200, Johannes Berg wrote:
> From: Johannes Berg <johannes.berg@intel.com>
>
> There's only a single case where has_80211_header is passed as true,
> which is in mac80211. Given that it's only a very simple check that
> needs to be done before calling it (calling
> __ieee80211_data_to_8023()
> and checking its return value), simple move that into the caller in
> order to simplify this function. The only additional cost this adds
> is the extra skb_push(), so reduce that by using __skb_push() as we
> know there's enough space, having pulled just before.
Obviously this is broken ... we need to have a frame without the outer
802.3 header, not with it, passed into the function.
johannes
prev parent reply other threads:[~2016-10-05 13:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-05 13:33 [PATCH] cfg80211: let ieee80211_amsdu_to_8023s() take only 802.3 header Johannes Berg
2016-10-05 13:57 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1475675837.5257.1.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=michael-dev@fami-braun.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.