All of lore.kernel.org
 help / color / mirror / Atom feed
From: Oliver Neukum <oneukum@suse.com>
To: Lukas Wunner <lukas@wunner.de>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
	Bjorn Helgaas <bhelgaas@google.com>,
	"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
	Mathias Nyman <mathias.nyman@linux.intel.com>,
	Pierre de Villemereuil <flyos@mailoo.org>,
	Alan Stern <stern@rowland.harvard.edu>,
	 linux-pci@vger.kernel.org, USB list <linux-usb@vger.kernel.org>
Subject: Re: USB hot-plug not working (ASUS TP301UA-C4028T)
Date: Thu, 06 Oct 2016 09:24:49 +0200	[thread overview]
Message-ID: <1475738689.12201.2.camel@suse.com> (raw)
In-Reply-To: <20161005204119.GA5961@wunner.de>

On Wed, 2016-10-05 at 22:41 +0200, Lukas Wunner wrote:
> The PCI core doesn't allow runtime PM by default.  Rather it calls
> pm_runtime_forbid() when the device is added (see pci_pm_init(),
> called
> indirectly from pci_device_add()).  PCI drivers need to explicitly
> call
> pm_runtime_allow(), typically from their ->probe hook.
> 
> If this xHC cannot signal wakeup, it shouldn't allow runtime PM in the
> first place.  Simple as that.

Presumably it can generate PME, just not in D0. The XHCI driver
could, albeit with a slight layering violation, check
that specific combination. But why put the code for a potentially
common problem into xhci?

	Regards
		Oliver

  reply	other threads:[~2016-10-06  7:24 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <57F4B9C5.60600@linux.intel.com>
2016-10-05 14:45 ` USB hot-plug not working (ASUS TP301UA-C4028T) Alan Stern
2016-10-05 18:54   ` Bjorn Helgaas
2016-10-05 20:41     ` Lukas Wunner
2016-10-06  7:24       ` Oliver Neukum [this message]
2016-10-06 14:42       ` Alan Stern
2016-10-08 10:31         ` Lukas Wunner
2016-10-10 21:06           ` Pierre de Villemereuil
2016-10-11 15:18           ` Alan Stern
2016-10-11 20:27             ` Pierre de Villemereuil
2016-10-12 18:23               ` Alan Stern
2016-10-13 20:58                 ` Pierre de Villemereuil
2016-10-13 21:11                   ` Alan Stern
2016-10-14 21:46                     ` Pierre de Villemereuil
2016-10-20 10:01             ` Lukas Wunner
2016-10-20 13:57               ` Alan Stern

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1475738689.12201.2.camel@suse.com \
    --to=oneukum@suse.com \
    --cc=bhelgaas@google.com \
    --cc=flyos@mailoo.org \
    --cc=helgaas@kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=lukas@wunner.de \
    --cc=mathias.nyman@linux.intel.com \
    --cc=rafael.j.wysocki@intel.com \
    --cc=stern@rowland.harvard.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.