Re: [PATCH] update-rc.d.bbclass: check that init script exists before running it

[Markus Lehtonen <markus.lehtonen@linux.intel.com>]

On Wed, 2016-10-05 at 16:51 +0200, Andreas Oberritter wrote:
> Hello Markus,
> 
> On 05.10.2016 16:11, Markus Lehtonen wrote:
> > Check that the init script that is going to be called in the prerm()
> > script really exists. There might be a packaging bug or the script
> > might've been removed already earlier in prerm().
> 
> isn't it called prerm in the first place because it's not supposed to
> remove any packaged files?

In the case of this bug it does not remove any packaged files. Update
-alternatives removes a symlink (created by itself)


> And if there's a packaging bug, we should IMO better add a sanity check
> there and abort the build.

First of all, this does not fix a build-time, but a run-time problem. And,
I think that the pre post etc scripts should basically never fail.


[YOCTO #10299]
> > 
> > Signed-off-by: Markus Lehtonen <markus.lehtonen@linux.intel.com>
> > ---
> >  meta/classes/update-rc.d.bbclass | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/meta/classes/update-rc.d.bbclass b/meta/classes/update
> > -rc.d.bbclass
> > index dfef2a2..24da547 100644
> > --- a/meta/classes/update-rc.d.bbclass
> > +++ b/meta/classes/update-rc.d.bbclass
> > @@ -37,7 +37,7 @@ fi
> >  }
> >  
> >  updatercd_prerm() {
> > -if [ -z "$D" ]; then
> > +if [ -z "$D" -a -f "${INIT_D_DIR}/${INITSCRIPT_NAME}" ]; then
> >  	${INIT_D_DIR}/${INITSCRIPT_NAME} stop
> >  fi
> >  }
> > 
>