From: Johannes Berg <johannes@sipsolutions.net>
To: michael-dev <michael-dev@fami-braun.de>
Cc: linux-wireless@vger.kernel.org, projekt-wlan@fem.tu-ilmenau.de,
netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH 3/3] mac80211: multicast to unicast conversion
Date: Thu, 06 Oct 2016 13:55:09 +0200 [thread overview]
Message-ID: <1475754909.2015.15.camel@sipsolutions.net> (raw)
In-Reply-To: <199ae52e4e3000456d8d65b81500d874@fami-braun.de>
On Thu, 2016-10-06 at 13:53 +0200, michael-dev wrote:
> Am 05.10.2016 13:58, schrieb Johannes Berg:
> >
> >
> > Anyway, perhaps this needs to change to take DMS/per-station into
> > account?
> >
> > Then again, this kind of setting - global multicast-to-unicast -
> > fundamentally *cannot* be done on a per-station basis, since if you
> > enable it for one station and not for another, the first station
> > that has it enabled would get the packets twice...
>
> as I see it, that is exactly how DMS is standarized.
>
> IEEE 802.11-2012 section 10.23.15 DMS procedures:
>
> "If the requested DMS is accepted by the AP, the AP shall send
> subsequent group addressed MSDUs that
> match the frame classifier specified in the DMS Descriptors to the
> requesting STA as A-MSDU subframes
> within an individually addressed A-MSDU frame (see 8.3.2.2 and
> 9.11)."
>
> -> so the multicast packets shall go out as unicast A-MSDU frames
> to stations that requested this
Correct.
> "The AP shall continue to transmit the matching frames as group
> addressed frames (see 9.3.6, and 10.2.1.16) if at least one
> associated
> STA has not requested DMS for these frames."
>
> -> so it will continue to send it as multicast frames as well.
>
> As with DMS the station requested DMS for a specific multicast
> address, it could then drop multicast frames addressed to the
> multicast address it registered for DMS.
Yes, the DMS spec tells it to do this. However, we can't implement non-
DMS similarly, because then the station won't request it and won't drop
the duplicates.
So for this non-standard multicast-to-unicast, it's all or nothing, it
can't be done for some stations only.
johannes
next prev parent reply other threads:[~2016-10-06 11:55 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-05 4:55 [PATCH 1/3] mac80211: remove unnecessary num_mcast_sta user Michael Braun
2016-10-05 4:55 ` [PATCH 2/3] mac80211: filter multicast data packets on AP / AP_VLAN Michael Braun
2016-10-05 9:56 ` Johannes Berg
2016-10-05 10:01 ` Johannes Berg
2016-10-05 4:55 ` [PATCH 3/3] mac80211: multicast to unicast conversion Michael Braun
2016-10-05 10:19 ` Johannes Berg
2016-10-05 10:19 ` Johannes Berg
2016-10-05 11:40 ` michael-dev
2016-10-05 11:40 ` michael-dev
2016-10-05 11:58 ` Johannes Berg
2016-10-06 11:53 ` michael-dev
2016-10-06 11:53 ` michael-dev
2016-10-06 11:55 ` Johannes Berg [this message]
-- strict thread matches above, loose matches on Subject: below --
2016-10-04 20:31 [PATCH 1/3] mac80211: remove unnecessary num_mcast_sta user Michael Braun
2016-10-04 20:31 ` [PATCH 3/3] mac80211: multicast to unicast conversion Michael Braun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1475754909.2015.15.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=michael-dev@fami-braun.de \
--cc=netdev@vger.kernel.org \
--cc=projekt-wlan@fem.tu-ilmenau.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.