From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
To: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
Tvrtko Ursulin <tursulin@ursulin.net>,
Intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 03/22] drm/i915: Shrink per-platform watermark configuration
Date: Fri, 07 Oct 2016 10:09:11 +0300 [thread overview]
Message-ID: <1475824151.3986.0.camel@linux.intel.com> (raw)
In-Reply-To: <23840881-27bb-8257-362e-97da3728abf5@linux.intel.com>
On to, 2016-10-06 at 08:37 +0100, Tvrtko Ursulin wrote:
> On 06/10/2016 07:58, Joonas Lahtinen wrote:
> > I rather meant how did you deduce the right datatype sizes?
> >
>
> Oh right, I've looked at the values stored in them and got extra
> confidence when the compiler did not complain.
The code repeatedly does ugly casts, it could be fixed in proper
manner, too. Add to your TODO ;)
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-10-07 7:09 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-05 12:33 [PATCH 00/22] .rodata diet Tvrtko Ursulin
2016-10-05 12:33 ` [PATCH 01/22] drm/i915: Shrink cxsr_latency_table Tvrtko Ursulin
2016-10-05 17:01 ` Ville Syrjälä
2016-10-06 7:35 ` Tvrtko Ursulin
2016-10-05 12:33 ` [PATCH 02/22] drm/i915: Shrink sdvo_cmd_names Tvrtko Ursulin
2016-10-13 14:03 ` Daniel Vetter
2016-10-05 12:33 ` [PATCH 03/22] drm/i915: Shrink per-platform watermark configuration Tvrtko Ursulin
2016-10-05 15:07 ` Joonas Lahtinen
2016-10-05 16:50 ` Tvrtko Ursulin
2016-10-05 16:53 ` Tvrtko Ursulin
2016-10-06 6:58 ` Joonas Lahtinen
2016-10-06 7:37 ` Tvrtko Ursulin
2016-10-07 7:09 ` Joonas Lahtinen [this message]
2016-10-05 17:11 ` Ville Syrjälä
2016-10-06 16:38 ` Tvrtko Ursulin
2016-10-06 16:50 ` Ville Syrjälä
2016-10-05 12:33 ` [PATCH 04/22] drm/i915: Make HAS_DDI and HAS_PCH_LPT_LP only take dev_priv Tvrtko Ursulin
2016-10-05 17:16 ` Ville Syrjälä
2016-10-06 7:39 ` Tvrtko Ursulin
2016-10-05 12:33 ` [PATCH 05/22] drm/i915: Make INTEL_PCH_TYPE & co " Tvrtko Ursulin
2016-10-05 12:33 ` [PATCH 06/22] drm/i915: Make HAS_GMCH_DISPLAY " Tvrtko Ursulin
2016-10-05 12:33 ` [PATCH 07/22] drm/i915: Make HAS_RUNTIME_PM " Tvrtko Ursulin
2016-10-05 12:33 ` [PATCH 08/22] drm/i915: Do not use INTEL_INFO(dev_priv)->ring_mask inside WARNs Tvrtko Ursulin
2016-10-05 14:01 ` Joonas Lahtinen
2016-10-05 12:33 ` [PATCH 09/22] drm/i915: Make IS_GEN-range macro only take dev_priv Tvrtko Ursulin
2016-10-05 12:33 ` [PATCH 10/22] drm/i915: Make INTEL_DEVID " Tvrtko Ursulin
2016-10-05 12:33 ` [PATCH 11/22] drm/i915: Make IS_IVYBRIDGE " Tvrtko Ursulin
2016-10-05 12:33 ` [PATCH 12/22] drm/i915: Make IS_BROADWELL " Tvrtko Ursulin
2016-10-05 12:33 ` [PATCH 13/22] drm/i915: Make IS_HASWELL " Tvrtko Ursulin
2016-10-05 12:33 ` [PATCH 14/22] drm/i915: Make IS_KABYLAKE " Tvrtko Ursulin
2016-10-05 12:33 ` [PATCH 15/22] drm/i915: Make IS_SKYLAKE " Tvrtko Ursulin
2016-10-05 12:33 ` [PATCH 16/22] drm/i915: Make IS_BROXTON " Tvrtko Ursulin
2016-10-05 12:33 ` [PATCH 17/22] drm/i915: Make HAS_L3_DPF " Tvrtko Ursulin
2016-10-05 12:33 ` [PATCH 18/22] drm/i915: Make IS_G4X " Tvrtko Ursulin
2016-10-05 12:33 ` [PATCH 19/22] drm/i915: Make IS_CHERRYVIEW " Tvrtko Ursulin
2016-10-05 12:33 ` [PATCH 20/22] drm/i915: Make IS_VALLEYVIEW " Tvrtko Ursulin
2016-10-05 12:33 ` [PATCH 21/22] drm/i915: Make INTEL_GEN " Tvrtko Ursulin
2016-10-05 12:33 ` [PATCH 22/22] drm/i915: Make IS_GEN macros " Tvrtko Ursulin
2016-10-05 13:01 ` [PATCH 00/22] .rodata diet Jani Nikula
2016-10-05 13:39 ` Tvrtko Ursulin
2016-10-05 13:54 ` Chris Wilson
2016-10-11 13:06 ` Daniel Vetter
2016-10-05 14:49 ` ✗ Fi.CI.BAT: warning for " Patchwork
2016-10-11 12:17 ` [PATCH 00/22] " David Weinehall
2016-10-11 13:15 ` Tvrtko Ursulin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1475824151.3986.0.camel@linux.intel.com \
--to=joonas.lahtinen@linux.intel.com \
--cc=Intel-gfx@lists.freedesktop.org \
--cc=tursulin@ursulin.net \
--cc=tvrtko.ursulin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.