From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41588) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bsR2N-0000AF-Gf for qemu-devel@nongnu.org; Fri, 07 Oct 2016 05:01:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bsR2M-0000mr-2i for qemu-devel@nongnu.org; Fri, 07 Oct 2016 05:01:51 -0400 Message-ID: <1475830901.13132.23.camel@redhat.com> From: Gerd Hoffmann Date: Fri, 07 Oct 2016 11:01:41 +0200 In-Reply-To: <1474984441-28516-11-git-send-email-kwolf@redhat.com> References: <1474984441-28516-1-git-send-email-kwolf@redhat.com> <1474984441-28516-11-git-send-email-kwolf@redhat.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 Subject: Re: [Qemu-devel] [PULL 10/18] block: Move 'discard' option to bdrv_open_common() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: qemu-block@nongnu.org, qemu-devel@nongnu.org On Di, 2016-09-27 at 15:53 +0200, Kevin Wolf wrote: > This enables its use for nested child nodes. The compatibility > between the 'discard' and 'detect-zeroes' setting is checked in > bdrv_open_common() now as the former setting isn't available before > calling bdrv_open() any more. Seems this change makes libvirt not see the discard option any more, "virsh start" throws this error now ... error: Failed to start domain fedora-org-xhci error: unsupported configuration: discard is not supported by this QEMU binary ... and git bisect found this commit. cheers, Gerd