From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f68.google.com (mail-wm0-f68.google.com [74.125.82.68]) by mail.openembedded.org (Postfix) with ESMTP id 7C245607A3 for ; Fri, 7 Oct 2016 11:55:01 +0000 (UTC) Received: by mail-wm0-f68.google.com with SMTP id f193so2607179wmg.2 for ; Fri, 07 Oct 2016 04:55:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:subject:from:to:date:in-reply-to:references:mime-version :content-transfer-encoding; bh=ArSEHCxoxYX0a32wCBs/55nZxUfUUdVD6R9DrzoW9o8=; b=QRZDZJl8TYdLDCX/0LsXbxKKy9sZ663UaD1Ta4LQDvG+c7pe5LHwOteZ2fjOzL7Ely vdOIKWR+8GjB9h7mvkD/w08zjzHJJAvBED7ra1idK0YqScfwblzYZDwaZuamd2Dk5WD3 oap3o2z8IrW74HxAxiva6RL//0Rwpve4YKOVYXXo5seCmudUMiUiXu4W0Ki5uay4QCKb U7tSI21XhuMmYimKtFv3RK1wzR2q8pAaEV1f2FLwOBZZgO4ir4PgI0iGwu1qUOB0yUFT +kE0A82YAmvxoga4kavB2VQxSxF4xG/EHbVsOOPAps79uN2oiX/dUlrHQjNX8uYlYWf3 Jvgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:subject:from:to:date:in-reply-to :references:mime-version:content-transfer-encoding; bh=ArSEHCxoxYX0a32wCBs/55nZxUfUUdVD6R9DrzoW9o8=; b=Yyr8cijRKRxsCu8DeOgGgNOONCSVOFHPH8cvPGCl4d5ITg02Ii5ORHxKjhiOlQaKC4 rbvSdFEKCXD20yyhxNQTmxstyiArGeihZa6dqZJ6mkYvz7uGoTb+Eup1a2hzHGQsjuVU oBgBJcmq2O7exNpcP4dI6eKBasVeJKq2HXnJap61Fmm1627hoTl6S72ChMwdazf1h/+q C15NDeVdbQ2b53tNbvm7hKZG6dnFbyJY5amSRvbE5ESatfjWZa6wzpLDz2rz82H5tMe6 uBoRuwwTcXDyTFhkHPoOrm3isCETPrUfNOVFFWSQXQNndCaOz565nINKuv84iWXxzUeq 5fog== X-Gm-Message-State: AA6/9RnPcCBNVRo3AqwuB6wlek+zOHJV2SGIkil3pAzK0mUT0YdDDmkoF4Rq4/BLfDrnIQ== X-Received: by 10.28.144.74 with SMTP id s71mr19615462wmd.65.1475841302175; Fri, 07 Oct 2016 04:55:02 -0700 (PDT) Received: from Saturn.local.all ([194.191.225.84]) by smtp.gmail.com with ESMTPSA id lz5sm19243565wjb.24.2016.10.07.04.55.01 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 07 Oct 2016 04:55:01 -0700 (PDT) Message-ID: <1475841300.2264.14.camel@gmail.com> From: Max Krummenacher To: openembedded-devel@lists.openembedded.org, schnitzeltony@googlemail.com Date: Fri, 07 Oct 2016 13:55:00 +0200 In-Reply-To: <1475831964-1993-4-git-send-email-schnitzeltony@googlemail.com> References: <1475831964-1993-1-git-send-email-schnitzeltony@googlemail.com> <1475831964-1993-4-git-send-email-schnitzeltony@googlemail.com> X-Mailer: Evolution 3.16.5 Mime-Version: 1.0 Subject: Re: [PATCH 4/5] florence: update 0.6.3 X-BeenThere: openembedded-devel@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Using the OpenEmbedded metadata to build Distributions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Oct 2016 11:55:02 -0000 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Resent, this time from the correct account. Hi Am Freitag, den 07.10.2016, 11:19 +0200 schrieb Andreas Müller: > * patches were either leftovers or do not match the code > * DESCRIPTION -> shortened SUMMARY 0.5.x requires gtk 2 and gstreamer 0.10 while 0.6.x requires gtk 3 and gstreamer 1.0. Would be nice to see this in the commit message. I guess gtk+3 also needs do go into DEPENDS, see below. Maybe the move from gtk 2 to 3 would even justify to add a new recipe florence3 while keeping the existing one? In this initial attempt to go to 0.6.3 Alexander added 'gsettings' to inherit, probably to address the #NOTICE in the recipe. https://www.mail-archive.com/openembedded-devel@lists.openembedded.org/ msg47990.html > Signed-off-by: Andreas Müller > --- > .../florence/files/0001-Fix-glib-includes.patch | 33 ------------ > ---------- > .../florence/files/fix-no-atspi-compile.patch | 30 ------------ > -------- > .../{florence_0.5.4.bb => florence_0.6.3.bb} | 15 +++++----- > 3 files changed, 7 insertions(+), 71 deletions(-) > delete mode 100644 meta-gnome/recipes-support/florence/files/0001 > -Fix-glib-includes.patch > delete mode 100644 meta-gnome/recipes-support/florence/files/fix-no > -atspi-compile.patch > rename meta-gnome/recipes-support/florence/{florence_0.5.4.bb => > florence_0.6.3.bb} (51%) > > diff --git a/meta-gnome/recipes-support/florence/files/0001-Fix-glib > -includes.patch b/meta-gnome/recipes-support/florence/files/0001-Fix > -glib-includes.patch > deleted file mode 100644 > index 83e598e..0000000 > --- a/meta-gnome/recipes-support/florence/files/0001-Fix-glib > -includes.patch > +++ /dev/null > @@ -1,33 +0,0 @@ > -From c8419ef05ff92ffa3de2e626eb6acd5d2df3baa1 Mon Sep 17 00:00:00 > 2001 > -From: =?UTF-8?q?Andreas=20M=C3=BCller?= < > schnitzeltony@googlemail.com> > -Date: Tue, 15 May 2012 13:40:05 +0200 > -Subject: [PATCH] Fix glib includes > -MIME-Version: 1.0 > -Content-Type: text/plain; charset=UTF-8 > -Content-Transfer-Encoding: 8bit > -Upstream-Status: unknown > - > -Signed-off-by: Andreas Müller > ---- > - src/trace.c | 5 +---- > - 1 files changed, 1 insertions(+), 4 deletions(-) > - > -diff --git a/src/trace.c b/src/trace.c > -index 5ea5c13..774c56d 100644 > ---- a/src/trace.c > -+++ b/src/trace.c > -@@ -21,10 +21,7 @@ > - > - #include "trace.h" > - #include "system.h" > --#include > --#include > --#include > --#include > -+#include > - #include > - #include > - > --- > -1.7.6.5 > - > diff --git a/meta-gnome/recipes-support/florence/files/fix-no-atspi > -compile.patch b/meta-gnome/recipes-support/florence/files/fix-no > -atspi-compile.patch > deleted file mode 100644 > index 0bb5dee..0000000 > --- a/meta-gnome/recipes-support/florence/files/fix-no-atspi > -compile.patch > +++ /dev/null > @@ -1,30 +0,0 @@ > -diff --git a/src/florence.c b/src/florence.c > -index b27c31b..feadefe 100644 > ---- a/src/florence.c > -+++ b/src/florence.c > -@@ -44,12 +44,6 @@ > - /* exit signal */ > - static int flo_exit=FALSE; > - > --#ifdef ENABLE_AT_SPI2 > --void flo_check_show (struct florence *florence, AtspiAccessible > *obj); > --#else > --void flo_check_show (struct florence *florence, Accessible *obj); > --#endif > -- > - /* Called on destroy event (systray quit or close window) */ > - void flo_destroy (void) > - { > -@@ -61,6 +55,12 @@ void flo_destroy (void) > - } > - > - #ifdef AT_SPI > -+#ifdef ENABLE_AT_SPI2 > -+void flo_check_show (struct florence *florence, AtspiAccessible > *obj); > -+#else > -+void flo_check_show (struct florence *florence, Accessible *obj); > -+#endif > -+ > - /* Called to destroy the icon */ > - void flo_icon_destroy (GtkWidget *widget, gpointer user_data) > - { > diff --git a/meta-gnome/recipes-support/florence/florence_0.5.4.bb > b/meta-gnome/recipes-support/florence/florence_0.6.3.bb > similarity index 51% > rename from meta-gnome/recipes-support/florence/florence_0.5.4.bb > rename to meta-gnome/recipes-support/florence/florence_0.6.3.bb > index dfdb6bd..4c08b9f 100644 > --- a/meta-gnome/recipes-support/florence/florence_0.5.4.bb > +++ b/meta-gnome/recipes-support/florence/florence_0.6.3.bb > @@ -1,4 +1,4 @@ > -DESCRIPTION = "Florence is a virtual keyboard (also called on-screen > -keyboard), which allows the user to input text through a > touchscreen." > +SUMMARY = "Florence is a virtual keyboard for touch screens" > HOMEPAGE = "http://florence.sourceforge.net/english.html" > > #NOTICE: If florence can't find its gconf settings, you need to > start florence with --config for one time and save the configuration > once. > @@ -6,15 +6,14 @@ HOMEPAGE = " > http://florence.sourceforge.net/english.html" > LICENSE = "GPLv2" > LIC_FILES_CHKSUM = > "file://COPYING;md5=59530bdf33659b29e73d4adb9f9f6552" > > -PR = "r1" > +DEPENDS = "gtk+ libxml2 libglade librsvg libxtst gconf cairo > intltool-native gnome-doc-utils libnotify gstreamer1.0" I guess on needs gtk+3 here now? > > -DEPENDS = "gtk+ libxml2 libglade librsvg libxtst gconf cairo > intltool-native gnome-doc-utils libnotify gstreamer" > - > -SRC_URI = "${SOURCEFORGE_MIRROR}/florence/florence/${PV} > -gtk2/florence-${PV}.tar.bz2 \ > - file://fix-no-atspi-compile.patch" > -SRC_URI[md5sum] = "8d5c2367a28485bfcf577650b0badab7" > -SRC_URI[sha256sum] = > "26d33aa20d5fbf34ceeded4c41cb922d2988b6082e33d9acc46dd7bfe56d31a1" > +SRC_URI = "${SOURCEFORGE_MIRROR}/project/${PN}/${PN}/${PV}/${PN} > -${PV}.tar.bz2" > +SRC_URI[md5sum] = "8775051d7352f75dec5a86dc9964e8e0" > +SRC_URI[sha256sum] = > "422992fd07d285be73cce721a203e22cee21320d69b0fda1579ce62944c5091e" > > inherit gettext autotools gconf pkgconfig > > EXTRA_OECONF = "--disable-scrollkeeper --without-docs --without-at > -spi --without-panelapplet --without-xrecord" > + > +FILES_${PN} += "${datadir}/glib-2.0/schemas"