From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dan.rpsys.net (5751f4a1.skybroadband.com [87.81.244.161]) by mail.openembedded.org (Postfix) with ESMTP id B8BAE71975 for ; Fri, 7 Oct 2016 15:48:44 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by dan.rpsys.net (8.14.4/8.14.4/Debian-4.1ubuntu1) with ESMTP id u97FmgUi020433; Fri, 7 Oct 2016 16:48:42 +0100 Received: from dan.rpsys.net ([127.0.0.1]) by localhost (dan.rpsys.net [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 5Pq6fBnn6KpC; Fri, 7 Oct 2016 16:48:42 +0100 (BST) Received: from hex ([192.168.3.34]) (authenticated bits=0) by dan.rpsys.net (8.14.4/8.14.4/Debian-4.1ubuntu1) with ESMTP id u97FmcHS020429 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=NOT); Fri, 7 Oct 2016 16:48:39 +0100 Message-ID: <1475855318.30475.633.camel@linuxfoundation.org> From: Richard Purdie To: Zubair Lutfullah Kakakhel , Mark Hatle , openembedded-core@lists.openembedded.org Date: Fri, 07 Oct 2016 16:48:38 +0100 In-Reply-To: <77aabb0f-ae71-2425-6a63-fabd27bed710@imgtec.com> References: <1475580681-55081-1-git-send-email-Zubair.Kakakhel@imgtec.com> <9c3c5cc4-02e0-4a95-c6f6-9a282701c240@windriver.com> <77aabb0f-ae71-2425-6a63-fabd27bed710@imgtec.com> X-Mailer: Evolution 3.18.5.2-0ubuntu3 Mime-Version: 1.0 Subject: Re: [PATCH 0/9] Add MIPS release 6 ISA support X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Oct 2016 15:48:49 -0000 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit On Fri, 2016-10-07 at 12:53 +0100, Zubair Lutfullah Kakakhel wrote: > On 10/06/2016 05:43 PM, Mark Hatle wrote: > > > > A few general comments.  I don't see an n32 variant > > implemented.  I'd suggest a > > follow on patch (vs a new version) to add n32. > > > > It looks like it's missing in the files modified by patches 6-9. > Thanks for the review. > Yes I haven't added the n32 variant on purpose at the moment. > Wanted to get this out to see if this is the correct approach. I've been torn on these patches, they're good but they've come in very late in the cycle for this kind of change. Since they're comparatively straight forward to review, I've merged them. This is partly because I wouldn't really want to backport changes like this later and it seemed likely that might be requested. What I will say though is that we really need to think about an "allmips", or "mipsarch" override, rather than all these duplicate lines for all mips variants. This is something we should fix early in the 2.3 cycle and should make some of this look a lot neater. It might be worth openening a bug for this in the bugzilla and assigning that to yourself, assuming you're happy to work on it? Cheers, Richard