All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Jiri Kosina <jikos@kernel.org>,
	Colin Ian King <colin.king@canonical.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [GIT PULL] trivial for 4.9
Date: Fri, 07 Oct 2016 13:33:21 -0700	[thread overview]
Message-ID: <1475872401.1945.17.camel@perches.com> (raw)
In-Reply-To: <CA+55aFyMPLmxKdYK70Omhpq3SehHqdA3L97mM5dsiw-OTnhG8Q@mail.gmail.com>

On Fri, 2016-10-07 at 13:25 -0700, Linus Torvalds wrote:
> I find this noise to add '\n' characters completely pointless. It's
> bogus stupid churn that doesn't actually make the source code better,
> and it also doesn't actually seem to fix any behavioral issues.
> 
> And if there are behavioral issues, they should (a) be pointed out and
> (b) be fixed.
> 
> In *no* case does it make sense to randomly just add newline
> characters without even having a reason for it.

It prevents random interleaving from those other
12000+ possible printk calls without an explicit
KERN_<LEVEL>

  reply	other threads:[~2016-10-07 20:33 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-07  8:51 [GIT PULL] trivial for 4.9 Jiri Kosina
2016-10-07 19:22 ` Linus Torvalds
2016-10-07 20:04   ` Joe Perches
2016-10-07 20:13     ` Linus Torvalds
2016-10-07 20:18       ` Joe Perches
2016-10-07 20:25         ` Linus Torvalds
2016-10-07 20:33           ` Joe Perches [this message]
2016-10-07 21:06             ` Linus Torvalds
2016-10-07 21:37               ` Linus Torvalds
2016-10-08  7:36                 ` Joe Perches
2016-10-10  5:48                 ` Joe Perches
2016-10-07 21:44               ` Joe Perches
2016-10-07 23:01                 ` Tony Luck
2016-10-07 23:09                   ` Tony Luck
2016-10-07 23:36                     ` Linus Torvalds
2016-10-08 13:16                     ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1475872401.1945.17.camel@perches.com \
    --to=joe@perches.com \
    --cc=colin.king@canonical.com \
    --cc=jikos@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.