From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shyam Saini Subject: Re: [PATCH 1/1] gpu: drm: gma500: Use vma_pages() Date: Mon, 10 Oct 2016 07:22:47 +0530 Message-ID: <1476064367.14200.0.camel@gmail.com> References: <1476054436-9378-1-git-send-email-mayhs11saini@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Patrik Jakobsson Cc: David Airlie , dri-devel , linux-kernel List-Id: dri-devel@lists.freedesktop.org On Mon, 2016-10-10 at 01:46 +0200, Patrik Jakobsson wrote: > On Mon, Oct 10, 2016 at 1:07 AM, Shyam Saini > wrote: > > > > Replace explicit computation of vma page count by a call to > > vma_pages() > Hi, I already have this patch in the "queue" from: > Muhammad Falak R Wani > > Will include that one when I get around to sending out a PR. > > Thanks > Patrik > > > > > > > Signed-off-by: Shyam Saini > > --- > >  drivers/gpu/drm/gma500/framebuffer.c | 2 +- > >  1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/gma500/framebuffer.c > > b/drivers/gpu/drm/gma500/framebuffer.c > > index 3a44e70..0fde850 100644 > > --- a/drivers/gpu/drm/gma500/framebuffer.c > > +++ b/drivers/gpu/drm/gma500/framebuffer.c > > @@ -124,7 +124,7 @@ static int psbfb_vm_fault(struct vm_area_struct > > *vma, struct vm_fault *vmf) > >         unsigned long phys_addr = (unsigned long)dev_priv- > > >stolen_base + > >                                   psbfb->gtt->offset; > > > > -       page_num = (vma->vm_end - vma->vm_start) >> PAGE_SHIFT; > > +       page_num = vma_pages(vma); > >         address = (unsigned long)vmf->virtual_address - (vmf->pgoff > > << PAGE_SHIFT); > > > >         vma->vm_page_prot = pgprot_noncached(vma->vm_page_prot); > > -- > > 2.7.4 > > No issue. Thanks