All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: Akanksha Srivastava <akanksha.dlf@gmail.com>
Cc: qemu-devel@nongnu.org, qemu-trivial@nongnu.org
Subject: Re: [Qemu-trivial] [PATCH v2] usb: Change *_exitfn return type from int to void
Date: Mon, 10 Oct 2016 09:31:45 +0200	[thread overview]
Message-ID: <1476084705.13132.26.camel@redhat.com> (raw)
In-Reply-To: <1475973519-9591-1-git-send-email-akanksha.dlf@gmail.com>

  Hi,

> -    cc->exitfn = passthru_exitfn;
> +    cc->exitfn = NULL;

cc struct is zero-initialized, so setting to NULL is not needed.
You can just drop the line instead.

cheers,
  Gerd



WARNING: multiple messages have this Message-ID (diff)
From: Gerd Hoffmann <kraxel@redhat.com>
To: Akanksha Srivastava <akanksha.dlf@gmail.com>
Cc: qemu-devel@nongnu.org, qemu-trivial@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2] usb: Change *_exitfn return type from int to void
Date: Mon, 10 Oct 2016 09:31:45 +0200	[thread overview]
Message-ID: <1476084705.13132.26.camel@redhat.com> (raw)
In-Reply-To: <1475973519-9591-1-git-send-email-akanksha.dlf@gmail.com>

  Hi,

> -    cc->exitfn = passthru_exitfn;
> +    cc->exitfn = NULL;

cc struct is zero-initialized, so setting to NULL is not needed.
You can just drop the line instead.

cheers,
  Gerd

  reply	other threads:[~2016-10-10  7:31 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-09  0:38 [Qemu-trivial] [PATCH v2] usb: Change *_exitfn return type from int to void Akanksha Srivastava
2016-10-09  0:38 ` [Qemu-devel] " Akanksha Srivastava
2016-10-10  7:31 ` Gerd Hoffmann [this message]
2016-10-10  7:31   ` Gerd Hoffmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1476084705.13132.26.camel@redhat.com \
    --to=kraxel@redhat.com \
    --cc=akanksha.dlf@gmail.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.