From: Johannes Berg <johannes@sipsolutions.net>
To: Michael Braun <michael-dev@fami-braun.de>
Cc: linux-wireless@vger.kernel.org, projekt-wlan@fem.tu-ilmenau.de
Subject: Re: [PATCH] mac80211: enable to inject a-msdu frames using monitor interface
Date: Mon, 10 Oct 2016 12:16:44 +0200 [thread overview]
Message-ID: <1476094604.7895.9.camel@sipsolutions.net> (raw)
In-Reply-To: <1475872162-2835-1-git-send-email-michael-dev@fami-braun.de>
On Fri, 2016-10-07 at 22:29 +0200, Michael Braun wrote:
>
> I guess the same is needed for packets with IEEE80211_TX_CTRL_AMSDU
> set.
I don't think that's true, since we don't get here after A-MSDU
building in mac80211.
> /* preserve EOSP bit */
> ack_policy = *p & IEEE80211_QOS_CTL_EOSP;
>
> + /* preserve A-MSDU bit for MONITOR interfaces to allow
> injecting
> + * A-MSDU frames
> + */
> + if (info->flags & IEEE80211_TX_CTL_INJECTED ||
> + info->control.flags & IEEE80211_TX_CTRL_AMSDU)
> + ack_policy |= *p & IEEE80211_QOS_CTL_A_MSDU_PRESENT;
However, why not just unconditionally preserve it?
johannes
prev parent reply other threads:[~2016-10-10 10:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-07 20:29 [PATCH] mac80211: enable to inject a-msdu frames using monitor interface Michael Braun
2016-10-10 10:16 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1476094604.7895.9.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=michael-dev@fami-braun.de \
--cc=projekt-wlan@fem.tu-ilmenau.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.