From: Johannes Berg <johannes@sipsolutions.net>
To: Michael Braun <michael-dev@fami-braun.de>
Cc: linux-wireless@vger.kernel.org, projekt-wlan@fem.tu-ilmenau.de,
netdev@vger.kernel.org
Subject: Re: [PATCH v5 3/4] cfg80211: configure multicast to unicast for AP interfaces
Date: Mon, 10 Oct 2016 12:28:33 +0200 [thread overview]
Message-ID: <1476095313.7895.12.camel@sipsolutions.net> (raw)
In-Reply-To: <1475865574-5384-3-git-send-email-michael-dev@fami-braun.de>
> *
> + * @NL80211_ATTR_MULTICAST_TO_UNICAST_ENABLED: Multicast packets
> should be
> + * send out as unicast to all stations.
You should document what type of attribute is expected. You probably
wanted a flag attribute, but ...
> + [NL80211_ATTR_MULTICAST_TO_UNICAST_ENABLED] = { .type =
> NLA_U8, },
have u8 in the policy, yet
> + enabled = nla_get_flag(nla);
actually use as a flag :)
In addition to that, I think you should clarify the "per-BSS" comment
in nl80211, and also clarify (at the same place) what kind of
functionality is expected from this.
johannes
next prev parent reply other threads:[~2016-10-10 10:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-07 18:39 [PATCH v5 1/4] mac80211: remove unnecessary num_mcast_sta user Michael Braun
2016-10-07 18:39 ` [PATCH v5 2/4] mac80211: filter multicast data packets on AP / AP_VLAN Michael Braun
2016-10-07 18:39 ` [PATCH v5 3/4] cfg80211: configure multicast to unicast for AP interfaces Michael Braun
2016-10-07 18:39 ` Michael Braun
2016-10-10 10:28 ` Johannes Berg [this message]
2016-10-07 18:39 ` [PATCH v5 4/4] mac80211: multicast to unicast conversion Michael Braun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1476095313.7895.12.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=michael-dev@fami-braun.de \
--cc=netdev@vger.kernel.org \
--cc=projekt-wlan@fem.tu-ilmenau.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.