From: Dennis Kaarsemaker <dennis@kaarsemaker.net>
To: Stefan Beller <sbeller@google.com>, gitster@pobox.com
Cc: git@vger.kernel.org, venv21@gmail.com
Subject: Re: [PATCH 1/2] submodule: ignore trailing slash on superproject URL
Date: Mon, 10 Oct 2016 21:58:36 +0200 [thread overview]
Message-ID: <1476129516.7457.6.camel@kaarsemaker.net> (raw)
In-Reply-To: <20161010175611.1058-1-sbeller@google.com>
[And now with CC to the list, sorry Stefan]
On Mon, 2016-10-10 at 10:56 -0700, Stefan Beller wrote:
> Before 63e95beb0 (2016-04-15, submodule: port resolve_relative_url from
> shell to C), it did not matter if the superprojects URL had a trailing
> slash or not. It was just chopped off as one of the first steps
> (The "remoteurl=${remoteurl%/}" near the beginning of
> resolve_relative_url(), which was removed in said commit).
>
> When porting this to the C version, an off-by-one error was introduced
> and we did not check the actual last character to be a slash, but the
> NULL delimiter.
>
> Reintroduce the behavior from before 63e95beb0, to ignore the trailing
> slash.
Looks good to me, and fixes my simple testcase and cloning epiphany
with trailing slash. Thanks!
D.
next prev parent reply other threads:[~2016-10-10 19:58 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-10 17:56 [PATCH 1/2] submodule: ignore trailing slash on superproject URL Stefan Beller
2016-10-10 17:56 ` [PATCH 2/2] submodule: ignore trailing slash in relative url Stefan Beller
2016-10-10 19:58 ` Dennis Kaarsemaker [this message]
2016-10-12 13:30 ` [PATCH 1/2] submodule: ignore trailing slash on superproject URL Johannes Schindelin
2016-10-12 17:06 ` Stefan Beller
2016-10-13 11:11 ` Johannes Schindelin
2016-10-17 7:10 ` Junio C Hamano
2016-10-17 17:58 ` Stefan Beller
2016-10-17 18:28 ` Junio C Hamano
2016-10-17 18:58 ` Stefan Beller
2016-10-17 19:16 ` Junio C Hamano
2016-10-17 19:32 ` Johannes Sixt
2016-10-17 20:07 ` Junio C Hamano
2016-10-18 20:06 ` Johannes Sixt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1476129516.7457.6.camel@kaarsemaker.net \
--to=dennis@kaarsemaker.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=sbeller@google.com \
--cc=venv21@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.