From mboxrd@z Thu Jan  1 00:00:00 1970
From: Chas Williams <3chas3@gmail.com>
Subject: Re: [PATCH 1/2] bnx2x: fix maximum PF queues
Date: Tue, 11 Oct 2016 09:56:11 -0400
Message-ID: <1476194171.1627.7.camel@gmail.com>
References: <1475732197-668-1-git-send-email-rasesh.mody@qlogic.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Cc: Dept-EngDPDKDev@qlogic.com
To: Rasesh Mody <rasesh.mody@qlogic.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mail-qk0-f195.google.com (mail-qk0-f195.google.com
 [209.85.220.195]) by dpdk.org (Postfix) with ESMTP id 59A112BA6
 for <dev@dpdk.org>; Tue, 11 Oct 2016 15:56:13 +0200 (CEST)
Received: by mail-qk0-f195.google.com with SMTP id n189so1461392qke.1
 for <dev@dpdk.org>; Tue, 11 Oct 2016 06:56:13 -0700 (PDT)
In-Reply-To: <1475732197-668-1-git-send-email-rasesh.mody@qlogic.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Wed, 2016-10-05 at 22:36 -0700, Rasesh Mody wrote:
> Fix the max number of PF rx/tx queues. Set the value based
> on BNX2X_MAX_RSS_COUNT() rather than hard coding it to 128.
> 
> Fixes: 540a211 ("bnx2x: driver core")
> 
> Signed-off-by: Rasesh Mody <rasesh.mody@qlogic.com>
> ---
>  drivers/net/bnx2x/bnx2x.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/bnx2x/bnx2x.c b/drivers/net/bnx2x/bnx2x.c
> index a49a07f..2bb4a84 100644
> --- a/drivers/net/bnx2x/bnx2x.c
> +++ b/drivers/net/bnx2x/bnx2x.c
> @@ -9556,8 +9556,8 @@ static void bnx2x_init_rte(struct bnx2x_softc *sc)
>  		sc->max_rx_queues = min(BNX2X_VF_MAX_QUEUES_PER_VF,
>  					sc->igu_sb_cnt);
>  	} else {
> -		sc->max_tx_queues = 128;
> -		sc->max_rx_queues = 128;
> +		sc->max_rx_queues = BNX2X_MAX_RSS_COUNT(sc);
> +		sc->max_tx_queues = sc->max_rx_queues;
>  	}
>  }

Technically, I think max_tx_queues would be max_rx_queues * max_cos.
However, I don't think there are any DPDK applications that would take
advantage of this.

Acked-By: Chas Williams <3chas3@gmail.com>