Re: [PATCH] mac80211: fix A-MSDU outer SA/DA

[Johannes Berg <johannes@sipsolutions.net>]

On Wed, 2016-10-12 at 09:53 +0200, Johannes Berg wrote:
> On Mon, 2016-10-10 at 18:52 +0200, Michael Braun wrote:
> > 
> > According to IEEE 802.11-2012 section 8.3.2 table 8-19, the outer
> > SA/DA of A-MSDU frames need to be changed depending on FromDS/ToDS
> > values.
> 
> "Need to" is perhaps a bit strongly worded, but whatever :)
> 
> I was going to write a long reply and whatever - but I think that's
> all moot. As far as I can tell, you got this completely wrong, as
> you're changing the *inner* headers, not the *outer* header as you
> should?

Oh, no, my mistake - this happens before 802.3->.11 conversion.

So this does look correct, but I don't like that you write to
amsdu_hdr.h_{source,dest} twice after the patch.

I think you should have da and sa variables and set those, and then
memcpy only once.

johannes