From: Johannes Berg <johannes@sipsolutions.net>
To: Michael Braun <michael-dev@fami-braun.de>
Cc: linux-wireless@vger.kernel.org, projekt-wlan@fem.tu-ilmenau.de,
Felix Fietkau <nbd@openwrt.org>
Subject: Re: [PATCHv4] mac80211: fix A-MSDU outer SA/DA
Date: Thu, 13 Oct 2016 08:56:21 +0200 [thread overview]
Message-ID: <1476341781.4904.4.camel@sipsolutions.net> (raw)
In-Reply-To: <1476337315-26845-1-git-send-email-michael-dev@fami-braun.de> (sfid-20161013_074406_501207_29437AE6)
Hi,
I think this looks good now. I'd prefer, however, doing the reorg that
gets rid of the memcpy() separately, that's now more or less orthogonal
to the changes you're making. I suspect it's due to you having just
edited the original, rather than starting from scratch, but I think it
makes sense to split it.
> + memcpy(amsdu_hdr->h_source, h_80211_src, ETH_ALEN);
> + memcpy(amsdu_hdr->h_dest, h_80211_dst, ETH_ALEN);
ether_addr_copy()? Alignment should be OK here.
johannes
next prev parent reply other threads:[~2016-10-13 7:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-13 5:41 [PATCHv4] mac80211: fix A-MSDU outer SA/DA Michael Braun
2016-10-13 6:56 ` Johannes Berg [this message]
2016-10-13 7:19 ` Felix Fietkau
2016-10-13 7:23 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1476341781.4904.4.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=michael-dev@fami-braun.de \
--cc=nbd@openwrt.org \
--cc=projekt-wlan@fem.tu-ilmenau.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.