From: Jeff Layton <jlayton@redhat.com>
To: NeilBrown <neilb@suse.com>,
Trond Myklebust <trond.myklebust@primarydata.com>,
Anna Schumaker <anna.schumaker@netapp.com>
Cc: Benjamin Coddington <bcodding@redhat.com>,
Linux NFS Mailing List <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH 0/6] NFSv4: Fix stateid used when flock locks in use. - V2
Date: Thu, 13 Oct 2016 11:31:01 -0400 [thread overview]
Message-ID: <1476372661.12134.14.camel@redhat.com> (raw)
In-Reply-To: <147633263771.766.17853370901003798934.stgit@noble>
On Thu, 2016-10-13 at 15:26 +1100, NeilBrown wrote:
> Thanks to prompting from Jeff I discovered that I could
> access the correct open-state when ftrunctate() is being used.
> That improves the setattr handling, removing some special cases.
>
> This series is based on the linux-next branch of
> git://git.linux-nfs.org/projects/anna/linux-nfs.git
>
> NeilBrown
>
> ---
>
> NeilBrown (6):
> NFS: remove l_pid field from nfs_lockowner
> NFSv4: add flock_owner to open context
> NFSv4: change nfs4_do_setattr to take an open_context instead of a nfs4_state.
> NFSv4: change nfs4_select_rw_stateid to take a lock_context inplace of lock_owner
> NFSv4: enhance nfs4_copy_lock_stateid to use a flock stateid if there is one
> NFS: discard nfs_lockowner structure.
>
>
> fs/nfs/dir.c | 6 +++---
> fs/nfs/inode.c | 14 +++++++-------
> fs/nfs/nfs4_fs.h | 2 +-
> fs/nfs/nfs4file.c | 2 +-
> fs/nfs/nfs4proc.c | 44 +++++++++++++++++++-------------------------
> fs/nfs/nfs4state.c | 25 ++++++++++++++-----------
> fs/nfs/pagelist.c | 3 +--
> fs/nfs/write.c | 3 +--
> include/linux/nfs_fs.h | 10 +++-------
> 9 files changed, 50 insertions(+), 59 deletions(-)
>
> --
> Signature
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
This all looks good to me aside from some minor documentation nits.
Kudos too on doing this with a net removal of code. :)
Reviewed-by: Jeff Layton <jlayton@redhat.com>
next prev parent reply other threads:[~2016-10-13 15:31 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-13 4:26 [PATCH 0/6] NFSv4: Fix stateid used when flock locks in use. - V2 NeilBrown
2016-10-13 4:26 ` [PATCH 1/6] NFS: remove l_pid field from nfs_lockowner NeilBrown
2016-10-13 4:26 ` [PATCH 5/6] NFSv4: enhance nfs4_copy_lock_stateid to use a flock stateid if there is one NeilBrown
2016-10-13 15:22 ` Jeff Layton
2016-10-14 0:22 ` NeilBrown
2016-10-14 10:49 ` Jeff Layton
2016-12-19 0:33 ` [PATCH] NFSv4: ensure __nfs4_find_lock_state returns consistent result NeilBrown
2016-10-13 4:26 ` [PATCH 2/6] NFSv4: add flock_owner to open context NeilBrown
2016-10-13 4:26 ` [PATCH 4/6] NFSv4: change nfs4_select_rw_stateid to take a lock_context inplace of lock_owner NeilBrown
2016-10-20 0:57 ` NeilBrown
2016-10-13 4:26 ` [PATCH 6/6] NFS: discard nfs_lockowner structure NeilBrown
2016-10-13 4:26 ` [PATCH 3/6] NFSv4: change nfs4_do_setattr to take an open_context instead of a nfs4_state NeilBrown
2016-11-02 15:49 ` Benjamin Coddington
2016-11-02 23:34 ` NeilBrown
2016-11-03 16:38 ` Benjamin Coddington
2016-11-03 23:12 ` Benjamin Coddington
2016-10-13 15:31 ` Jeff Layton [this message]
2016-10-18 21:52 ` [PATCH 0/6] NFSv4: Fix stateid used when flock locks in use. - V2 NeilBrown
2016-11-18 4:59 ` NeilBrown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1476372661.12134.14.camel@redhat.com \
--to=jlayton@redhat.com \
--cc=anna.schumaker@netapp.com \
--cc=bcodding@redhat.com \
--cc=linux-nfs@vger.kernel.org \
--cc=neilb@suse.com \
--cc=trond.myklebust@primarydata.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.