From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paulo Zanoni Subject: Re: [PATCH 10/10] drm/i915/gen9: Don't wrap strings in verify_wm_state() Date: Thu, 13 Oct 2016 18:18:38 -0300 Message-ID: <1476393518.2478.50.camel@intel.com> References: <1475885497-6094-1-git-send-email-cpaul@redhat.com> <1475885497-6094-11-git-send-email-cpaul@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1475885497-6094-11-git-send-email-cpaul@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Lyude , intel-gfx@lists.freedesktop.org Cc: David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Daniel Vetter List-Id: dri-devel@lists.freedesktop.org RW0gU2V4LCAyMDE2LTEwLTA3IMOgcyAyMDoxMSAtMDQwMCwgTHl1ZGUgZXNjcmV2ZXU6CgpCaWtl c2hlZGluZzogaXQgd291bGQgYmUgbmljZSB0byB3cml0ZSBhIGNvbW1pdCBtZXNzYWdlIGV4cGxh aW5pbmcgd2h5LApldmVuIGlmIHRoZSBtZXNzYWdlIGp1c3QgdGVsbHMgdGhlIHVzZXIgdG8gcmVh ZApEb2N1bWVudGF0aW9uL0NvZGluZ1N0eWxlLgoKUmV2aWV3ZWQtYnk6IFBhdWxvIFphbm9uaSA8 cGF1bG8uci56YW5vbmlAaW50ZWwuY29tPgoKPiBTaWduZWQtb2ZmLWJ5OiBMeXVkZSA8Y3BhdWxA cmVkaGF0LmNvbT4KPiBDYzogTWFhcnRlbiBMYW5raG9yc3QgPG1hYXJ0ZW4ubGFua2hvcnN0QGxp bnV4LmludGVsLmNvbT4KPiBDYzogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4 LmludGVsLmNvbT4KPiBDYzogUGF1bG8gWmFub25pIDxwYXVsby5yLnphbm9uaUBpbnRlbC5jb20+ Cj4gLS0tCj4gwqBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMgfCA2ICsrLS0t LQo+IMKgMSBmaWxlIGNoYW5nZWQsIDIgaW5zZXJ0aW9ucygrKSwgNCBkZWxldGlvbnMoLSkKPiAK PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gYi9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPiBpbmRleCAyYzY4MmJjLi42MTkx YmFmIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+ ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+IEBAIC0xMzQ5OCw4 ICsxMzQ5OCw3IEBAIHN0YXRpYyB2b2lkIHZlcmlmeV93bV9zdGF0ZShzdHJ1Y3QgZHJtX2NydGMK PiAqY3J0YywKPiDCoAkJc3dfZGRiX2VudHJ5ID0gJnN3X2RkYi0+cGxhbmVbcGlwZV1bcGxhbmVd Owo+IMKgCj4gwqAJCWlmICghc2tsX2RkYl9lbnRyeV9lcXVhbChod19kZGJfZW50cnksCj4gc3df ZGRiX2VudHJ5KSkgewo+IC0JCQlEUk1fRVJST1IoIm1pc21hdGNoIGluIEREQiBzdGF0ZSBwaXBl ICVjCj4gcGxhbmUgJWQgIgo+IC0JCQkJwqDCoCIoZXhwZWN0ZWQgKCV1LCV1KSwgZm91bmQKPiAo JXUsJXUpKVxuIiwKPiArCQkJRFJNX0VSUk9SKCJtaXNtYXRjaCBpbiBEREIgc3RhdGUgcGlwZSAl Ywo+IHBsYW5lICVkIChleHBlY3RlZCAoJXUsJXUpLCBmb3VuZCAoJXUsJXUpKVxuIiwKPiDCoAkJ CQnCoMKgcGlwZV9uYW1lKHBpcGUpLCBwbGFuZSArIDEsCj4gwqAJCQkJwqDCoHN3X2RkYl9lbnRy eS0+c3RhcnQsIHN3X2RkYl9lbnRyeS0KPiA+ZW5kLAo+IMKgCQkJCcKgwqBod19kZGJfZW50cnkt PnN0YXJ0LCBod19kZGJfZW50cnktCj4gPmVuZCk7Cj4gQEAgLTEzNTQ5LDggKzEzNTQ4LDcgQEAg c3RhdGljIHZvaWQgdmVyaWZ5X3dtX3N0YXRlKHN0cnVjdCBkcm1fY3J0Ywo+ICpjcnRjLAo+IMKg CQlzd19kZGJfZW50cnkgPSAmc3dfZGRiLT5wbGFuZVtwaXBlXVtQTEFORV9DVVJTT1JdOwo+IMKg Cj4gwqAJCWlmICghc2tsX2RkYl9lbnRyeV9lcXVhbChod19kZGJfZW50cnksCj4gc3dfZGRiX2Vu dHJ5KSkgewo+IC0JCQlEUk1fRVJST1IoIm1pc21hdGNoIGluIEREQiBzdGF0ZSBwaXBlICVjCj4g Y3Vyc29yICIKPiAtCQkJCcKgwqAiKGV4cGVjdGVkICgldSwldSksIGZvdW5kCj4gKCV1LCV1KSlc biIsCj4gKwkJCURSTV9FUlJPUigibWlzbWF0Y2ggaW4gRERCIHN0YXRlIHBpcGUgJWMKPiBjdXJz b3IgKGV4cGVjdGVkICgldSwldSksIGZvdW5kICgldSwldSkpXG4iLAo+IMKgCQkJCcKgwqBwaXBl X25hbWUocGlwZSksCj4gwqAJCQkJwqDCoHN3X2RkYl9lbnRyeS0+c3RhcnQsIHN3X2RkYl9lbnRy eS0KPiA+ZW5kLAo+IMKgCQkJCcKgwqBod19kZGJfZW50cnktPnN0YXJ0LCBod19kZGJfZW50cnkt Cj4gPmVuZCk7Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f CkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpo dHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756867AbcJMVWN (ORCPT ); Thu, 13 Oct 2016 17:22:13 -0400 Received: from mga07.intel.com ([134.134.136.100]:18316 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756750AbcJMVWH (ORCPT ); Thu, 13 Oct 2016 17:22:07 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,489,1473145200"; d="scan'208";a="1064508307" Message-ID: <1476393518.2478.50.camel@intel.com> Subject: Re: [PATCH 10/10] drm/i915/gen9: Don't wrap strings in verify_wm_state() From: Paulo Zanoni To: Lyude , intel-gfx@lists.freedesktop.org Cc: Maarten Lankhorst , Ville =?ISO-8859-1?Q?Syrj=E4l=E4?= , Daniel Vetter , Jani Nikula , David Airlie , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Date: Thu, 13 Oct 2016 18:18:38 -0300 In-Reply-To: <1475885497-6094-11-git-send-email-cpaul@redhat.com> References: <1475885497-6094-1-git-send-email-cpaul@redhat.com> <1475885497-6094-11-git-send-email-cpaul@redhat.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.20.5 (3.20.5-1.fc24) Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Sex, 2016-10-07 às 20:11 -0400, Lyude escreveu: Bikesheding: it would be nice to write a commit message explaining why, even if the message just tells the user to read Documentation/CodingStyle. Reviewed-by: Paulo Zanoni > Signed-off-by: Lyude > Cc: Maarten Lankhorst > Cc: Ville Syrjälä > Cc: Paulo Zanoni > --- >  drivers/gpu/drm/i915/intel_display.c | 6 ++---- >  1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/i915/intel_display.c > b/drivers/gpu/drm/i915/intel_display.c > index 2c682bc..6191baf 100644 > --- a/drivers/gpu/drm/i915/intel_display.c > +++ b/drivers/gpu/drm/i915/intel_display.c > @@ -13498,8 +13498,7 @@ static void verify_wm_state(struct drm_crtc > *crtc, >   sw_ddb_entry = &sw_ddb->plane[pipe][plane]; >   >   if (!skl_ddb_entry_equal(hw_ddb_entry, > sw_ddb_entry)) { > - DRM_ERROR("mismatch in DDB state pipe %c > plane %d " > -   "(expected (%u,%u), found > (%u,%u))\n", > + DRM_ERROR("mismatch in DDB state pipe %c > plane %d (expected (%u,%u), found (%u,%u))\n", >     pipe_name(pipe), plane + 1, >     sw_ddb_entry->start, sw_ddb_entry- > >end, >     hw_ddb_entry->start, hw_ddb_entry- > >end); > @@ -13549,8 +13548,7 @@ static void verify_wm_state(struct drm_crtc > *crtc, >   sw_ddb_entry = &sw_ddb->plane[pipe][PLANE_CURSOR]; >   >   if (!skl_ddb_entry_equal(hw_ddb_entry, > sw_ddb_entry)) { > - DRM_ERROR("mismatch in DDB state pipe %c > cursor " > -   "(expected (%u,%u), found > (%u,%u))\n", > + DRM_ERROR("mismatch in DDB state pipe %c > cursor (expected (%u,%u), found (%u,%u))\n", >     pipe_name(pipe), >     sw_ddb_entry->start, sw_ddb_entry- > >end, >     hw_ddb_entry->start, hw_ddb_entry- > >end);