From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mail.openembedded.org (Postfix) with ESMTP id 4B22760068 for ; Thu, 13 Oct 2016 23:10:25 +0000 (UTC) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga101.fm.intel.com with ESMTP; 13 Oct 2016 16:10:26 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,490,1473145200"; d="scan'208";a="19372553" Received: from alimonb-mobl1.zpn.intel.com ([10.219.5.32]) by fmsmga006.fm.intel.com with ESMTP; 13 Oct 2016 16:10:26 -0700 From: =?UTF-8?q?An=C3=ADbal=20Lim=C3=B3n?= To: bitbake-devel@lists.openembedded.org Date: Thu, 13 Oct 2016 18:11:34 -0500 Message-Id: <1476400294-17333-1-git-send-email-anibal.limon@linux.intel.com> X-Mailer: git-send-email 2.1.4 MIME-Version: 1.0 Cc: brian.avery@intel.com, benjamin.esquivel@intel.com Subject: [PATCH] bb.event: fix infinite loop on print_ui_queue X-BeenThere: bitbake-devel@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussion that advance bitbake development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 Oct 2016 23:10:26 -0000 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit If bitbake ends before _uiready and bb.event.LogHandler was add to the bitbake logger it causes an infinite loop when logging something. The scenario is print_ui_queue is called at exit and executes the log handlers [2] one of them is bb.event.LogHandler this handler appends the same entry to ui_queue causing the inifine loop [3]. In order to fix we need to keep track of events already handled to avoid the infinite loop. [YOCTO #10399] [1] https://bugzilla.yoctoproject.org/show_bug.cgi?id=10399#c0 [2] http://git.openembedded.org/bitbake/tree/lib/bb/event.py?id=41d9cd41d40b04746c82b4a940dca47df02514fc#n156 [3] http://git.openembedded.org/bitbake/tree/lib/bb/event.py?id=41d9cd41d40b04746c82b4a940dca47df02514fc#n164 Signed-off-by: Aníbal Limón --- lib/bb/event.py | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/lib/bb/event.py b/lib/bb/event.py index c5a5f94..8464e06 100644 --- a/lib/bb/event.py +++ b/lib/bb/event.py @@ -139,7 +139,11 @@ def print_ui_queue(): # First check to see if we have any proper messages msgprint = False + events_handled = [] for event in ui_queue: + if event in events_handled: + continue + if isinstance(event, logging.LogRecord): if event.levelno > logging.DEBUG: if event.levelno >= logging.WARNING: @@ -148,14 +152,20 @@ def print_ui_queue(): logger.addHandler(stdout) logger.handle(event) msgprint = True + events_handled.append(event) if msgprint: return # Nope, so just print all of the messages we have (including debug messages) logger.addHandler(stdout) + events_handled = [] for event in ui_queue: + if event in events_handled: + continue + if isinstance(event, logging.LogRecord): logger.handle(event) + events_handled.append(event) def fire_ui_handlers(event, d): global _thread_lock -- 2.1.4