From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lyude Subject: Re: [PATCH v3 00/10] Start of skl watermark cleanup Date: Sun, 16 Oct 2016 19:21:02 -0400 Message-ID: <1476660062.19759.0.camel@redhat.com> References: <1476480722-13015-1-git-send-email-cpaul@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1476480722-13015-1-git-send-email-cpaul@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: intel-gfx@lists.freedesktop.org Cc: Daniel Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org UHVzaGVkIHBhdGNoZXMgMS00IGluIHRoaXMgc2VyaWVzICh3aXRoIHNvbWUgdmVyeSBzbWFsbCBz dHlsZSBjaGFuZ2VzCnRvIG1ha2UgY2hlY2twYXRjaCBoYXBweSksIGRybS1pbnRlbC1uaWdodGx5 IGFsc28gcmVidWlsdC4KCk9uIEZyaSwgMjAxNi0xMC0xNCBhdCAxNzozMSAtMDQwMCwgTHl1ZGUg d3JvdGU6Cj4gV2hpbGUgaXQgKG1vc3RseSkgd29ya3MsIHRoZSBjb2RlIGZvciBoYW5kbGluZyB3 YXRlcm1hcmtzIG9uIFNreWxha2UKPiBoYXMgYmVlbgo+IGtpbmQgb2YgdWdseSBmb3IgYSB3aGls ZS4gQXMgd2VsbCBhIGxvdCBvZiBpdCBpc24ndCB0aGF0IGZyaWVuZGx5IHRvCj4gYXRvbWljCj4g dHJhbnNhY3Rpb25zLCBMb3RzIG9mIGNvcHkgcGFzdGUsIHJlZHVuZGFudCB3bSB2YWx1ZXMsIGV0 Yy4gV2hpbGUKPiB0aGlzIGlzbid0IGEKPiBmdWxsIGNsZWFudXAsIGl0J3MgYSBnb29kIHN0YXJ0 LiBBcyB3ZWxsLCB3ZSBhZGQgYSBjb3VwbGUgb2YgZmVhdHVyZXMKPiBmb3IKPiBtYWtpbmcgZGVi dWdnaW5nIHdhdGVybWFya3MgYSBsaXR0bGUgZWFzaWVyLgo+IAo+IFJlYmFzZWQgZm9yIGxhdGVz dCBuaWdodGx5LCBuZXcgci1icyBhZGRlZCArIHNvbWUgY2hhbmdlcwo+IAo+IEx5dWRlICgxMCk6 Cj4gwqAgZHJtL2k5MTUvc2tsOiBNb3ZlIHBlci1waXBlIGRkYiBhbGxvY2F0aW9ucyBpbnRvIGNy dGMgc3RhdGVzCj4gwqAgZHJtL2k5MTUvc2tsOiBSZW1vdmUgbGluZXRpbWUgZnJvbSBza2xfd21f dmFsdWVzCj4gwqAgZHJtL2k5MTUvZ2VuOTogTWFrZSBza2xfd21fbGV2ZWwgcGVyLXBsYW5lCj4g wqAgZHJtL2k5MTUvZ2VuOTogQ2xlYW51cCBza2xfcGlwZV93bV9hY3RpdmVfc3RhdGUKPiDCoCBk cm0vaTkxNS9nZW45OiBHZXQgcmlkIG9mIHJlZHVuZGFudCB3YXRlcm1hcmsgdmFsdWVzCj4gwqAg ZHJtL2k5MTUvZ2VuOTogQWRkIGRkYiBjaGFuZ2VzIHRvIGF0b21pYyBkZWJ1ZyBvdXRwdXQKPiDC oCBkcm0vaTkxNS9nZW45OiBNYWtlIHNrbF9waXBlX3dtX2dldF9od19zdGF0ZSgpIHJldXNhYmxl Cj4gwqAgZHJtL2k5MTUvZ2VuOTogQWRkIHNrbF93bV9sZXZlbF9lcXVhbHMoKQo+IMKgIGRybS9p OTE1L2dlbjk6IEFjdHVhbGx5IHZlcmlmeSBXTSBsZXZlbHMgaW4gdmVyaWZ5X3dtX3N0YXRlKCkK PiDCoCBkcm0vaTkxNS9nZW45OiBEb24ndCB3cmFwIHN0cmluZ3MgaW4gdmVyaWZ5X3dtX3N0YXRl KCkKPiAKPiDCoGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmjCoMKgwqDCoMKgwqB8wqDC oDEwICstCj4gwqBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMgfCAxMzggKysr KysrKystLS0KPiDCoGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rydi5owqDCoMKgwqDCoHzC oMKgMjQgKy0KPiDCoGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3BtLmPCoMKgwqDCoMKgwqB8 IDQ2NiArKysrKysrKysrKysrKysrKy0tLS0tLQo+IC0tLS0tLS0tLS0tLQo+IMKgZHJpdmVycy9n cHUvZHJtL2k5MTUvaW50ZWxfc3ByaXRlLmPCoMKgfMKgwqDCoDggKy0KPiDCoDUgZmlsZXMgY2hh bmdlZCwgMzU1IGluc2VydGlvbnMoKyksIDI5MSBkZWxldGlvbnMoLSkKPiAKLS0gCkNoZWVycywK CUx5dWRlCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRy aS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRw czovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756957AbcJPXVP (ORCPT ); Sun, 16 Oct 2016 19:21:15 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34710 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756493AbcJPXVF (ORCPT ); Sun, 16 Oct 2016 19:21:05 -0400 Message-ID: <1476660062.19759.0.camel@redhat.com> Subject: Re: [PATCH v3 00/10] Start of skl watermark cleanup From: Lyude To: intel-gfx@lists.freedesktop.org Cc: Daniel Vetter , Jani Nikula , David Airlie , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Date: Sun, 16 Oct 2016 19:21:02 -0400 In-Reply-To: <1476480722-13015-1-git-send-email-cpaul@redhat.com> References: <1476480722-13015-1-git-send-email-cpaul@redhat.com> Organization: Red Hat Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Sun, 16 Oct 2016 23:21:04 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Pushed patches 1-4 in this series (with some very small style changes to make checkpatch happy), drm-intel-nightly also rebuilt. On Fri, 2016-10-14 at 17:31 -0400, Lyude wrote: > While it (mostly) works, the code for handling watermarks on Skylake > has been > kind of ugly for a while. As well a lot of it isn't that friendly to > atomic > transactions, Lots of copy paste, redundant wm values, etc. While > this isn't a > full cleanup, it's a good start. As well, we add a couple of features > for > making debugging watermarks a little easier. > > Rebased for latest nightly, new r-bs added + some changes > > Lyude (10): >   drm/i915/skl: Move per-pipe ddb allocations into crtc states >   drm/i915/skl: Remove linetime from skl_wm_values >   drm/i915/gen9: Make skl_wm_level per-plane >   drm/i915/gen9: Cleanup skl_pipe_wm_active_state >   drm/i915/gen9: Get rid of redundant watermark values >   drm/i915/gen9: Add ddb changes to atomic debug output >   drm/i915/gen9: Make skl_pipe_wm_get_hw_state() reusable >   drm/i915/gen9: Add skl_wm_level_equals() >   drm/i915/gen9: Actually verify WM levels in verify_wm_state() >   drm/i915/gen9: Don't wrap strings in verify_wm_state() > >  drivers/gpu/drm/i915/i915_drv.h      |  10 +- >  drivers/gpu/drm/i915/intel_display.c | 138 ++++++++--- >  drivers/gpu/drm/i915/intel_drv.h     |  24 +- >  drivers/gpu/drm/i915/intel_pm.c      | 466 +++++++++++++++++------ > ------------ >  drivers/gpu/drm/i915/intel_sprite.c  |   8 +- >  5 files changed, 355 insertions(+), 291 deletions(-) > -- Cheers, Lyude