From: Johannes Berg <johannes@sipsolutions.net>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Andy Lutomirski <luto@amacapital.net>,
Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
"<netdev@vger.kernel.org>" <netdev@vger.kernel.org>,
Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
"<linux-wireless@vger.kernel.org>"
<linux-wireless@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Jouni Malinen <j@w1.fi>
Subject: Re: [PATCH] crypto: ccm - avoid scatterlist for MAC encryption
Date: Mon, 17 Oct 2016 09:57:39 +0200 [thread overview]
Message-ID: <1476691059.19992.6.camel@sipsolutions.net> (raw)
In-Reply-To: <CAKv+Gu9EPAF+Oihz0tXCqWURGom-wgSPCMp0dEHHnxqw-pYYJw@mail.gmail.com> (sfid-20161017_095011_197525_132B0910)
On Mon, 2016-10-17 at 08:50 +0100, Ard Biesheuvel wrote:
> I just realised that patch should probably use
> aead_request_alloc/aead_request_free [and drop the memset]. That also
> fixes the latent bug where the alignment of the req ctx is not take
> into account.
Good point, I'll fix that up.
> >
> > >
> > > Also, regarding your __percpu patch: those are located in the
> > > vmalloc
> > > area as well, at least on arm64, and likely other architectures
> > > too.
> >
> > Crap. Any other bright ideas?
> >
>
> kmem_cache_create() and kmem_cache_alloc()
for the aad/b0/j0/etc? Hmm. Yeah I guess we should do those dynamically
as well then.
johannes
next prev parent reply other threads:[~2016-10-17 7:57 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-15 17:16 [PATCH] crypto: ccm - avoid scatterlist for MAC encryption Ard Biesheuvel
2016-10-17 7:28 ` Johannes Berg
2016-10-17 7:37 ` Ard Biesheuvel
2016-10-17 7:47 ` Johannes Berg
2016-10-17 7:50 ` Ard Biesheuvel
2016-10-17 7:57 ` Johannes Berg [this message]
2016-10-17 17:08 ` Andy Lutomirski
2016-10-17 17:21 ` Ard Biesheuvel
2016-10-19 3:31 ` Herbert Xu
2016-10-19 3:31 ` Herbert Xu
2016-10-19 7:43 ` Johannes Berg
2016-10-19 15:08 ` Ard Biesheuvel
2016-10-19 15:59 ` Ben Greear
2016-10-19 16:00 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1476691059.19992.6.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=ard.biesheuvel@linaro.org \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=j@w1.fi \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=netdev@vger.kernel.org \
--cc=sergey.senozhatsky.work@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.