From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH v2 1/3] drm/i915: Bump object bookkeeping to u64 from size_t
Date: Mon, 17 Oct 2016 12:48:17 +0300 [thread overview]
Message-ID: <1476697697.3081.7.camel@linux.intel.com> (raw)
In-Reply-To: <20161017080007.12215-1-chris@chris-wilson.co.uk>
On ma, 2016-10-17 at 09:00 +0100, Chris Wilson wrote:
> Internally we allow for using more objects than a single process can
> allocate, i.e. we allow for a 64bit GPU address space even on a 32bit
> system. Using size_t may oveerflow.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
How might we get more than size_t passed in? I only notice a single
instance which uses obj.base->size which is size_t.
So I'd not change the function parameters, only the sum. With that;
Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-10-17 9:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-17 8:00 [PATCH v2 1/3] drm/i915: Bump object bookkeeping to u64 from size_t Chris Wilson
2016-10-17 8:00 ` [PATCH v2 2/3] drm/i915: Document our internal limit on object size Chris Wilson
2016-10-18 9:27 ` Tvrtko Ursulin
2016-10-18 9:47 ` Chris Wilson
2016-10-17 8:00 ` [PATCH v2 3/3] drm/i915: Limit the scattergather coalescing to 32bits Chris Wilson
2016-10-18 9:33 ` Tvrtko Ursulin
2016-10-18 10:00 ` Chris Wilson
2016-10-17 8:50 ` ✗ Fi.CI.BAT: warning for series starting with [v2,1/3] drm/i915: Bump object bookkeeping to u64 from size_t Patchwork
2016-10-17 9:48 ` Joonas Lahtinen [this message]
2016-10-17 9:53 ` [PATCH v2 1/3] " Chris Wilson
2016-10-18 9:20 ` Tvrtko Ursulin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1476697697.3081.7.camel@linux.intel.com \
--to=joonas.lahtinen@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.