From: Johannes Berg <johannes@sipsolutions.net>
To: michael-dev <michael-dev@fami-braun.de>
Cc: projekt-wlan@fem.tu-ilmenau.de, Fietkau <nbd@openwrt.org>,
Felix@mail.fem.tu-ilmenau.de, linux-wireless@vger.kernel.org
Subject: Re: [Projekt-wlan] [PATCHv5 2/2] mac80211: fix A-MSDU outer SA/DA
Date: Mon, 17 Oct 2016 12:39:31 +0200 [thread overview]
Message-ID: <1476700771.19992.20.camel@sipsolutions.net> (raw)
In-Reply-To: <d793195b149aebb974dd596632d2ba83@fami-braun.de>
On Mon, 2016-10-17 at 12:29 +0200, michael-dev wrote:
>
> ether_addr_copy requires both arguments to be __aligned(2) according
> to
> include/linux/etherdevice.h.
> bssid might be sdata->u.mgd.bssid, which is bssid in struct
> ieee80211_if_managed, but neither sdata->u, sdata->u.mgd nor
> sdata->u.mgd.bssid seem to be declared as __aligned(2).So
> ether_addr_copy should not be used.
They are in fact aligned today, given that they occur after a pointer.
However, I did add the __aligned(2) annotation to make that plenty
clear for the future.
johannes
next prev parent reply other threads:[~2016-10-17 10:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-15 11:28 [PATCHv5 1/2] mac80211: avoid extra memcpy in A-MSDU head creation Michael Braun
2016-10-15 11:28 ` [PATCHv5 2/2] mac80211: fix A-MSDU outer SA/DA Michael Braun
2016-10-17 9:44 ` Johannes Berg
2016-10-17 10:29 ` [Projekt-wlan] " michael-dev
2016-10-17 10:39 ` Johannes Berg [this message]
2016-10-17 9:41 ` [PATCHv5 1/2] mac80211: avoid extra memcpy in A-MSDU head creation Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1476700771.19992.20.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=Felix@mail.fem.tu-ilmenau.de \
--cc=linux-wireless@vger.kernel.org \
--cc=michael-dev@fami-braun.de \
--cc=nbd@openwrt.org \
--cc=projekt-wlan@fem.tu-ilmenau.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.