From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kirti Wankhede Subject: [PATCH v9 07/12] vfio: Introduce vfio_set_irqs_validate_and_prepare() Date: Tue, 18 Oct 2016 02:52:07 +0530 Message-ID: <1476739332-4911-8-git-send-email-kwankhede@nvidia.com> References: <1476739332-4911-1-git-send-email-kwankhede@nvidia.com> Mime-Version: 1.0 Content-Type: text/plain Cc: , , , , , , Kirti Wankhede To: , , , Return-path: In-Reply-To: <1476739332-4911-1-git-send-email-kwankhede@nvidia.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org Vendor driver using mediated device framework would use same mechnism to validate and prepare IRQs. Introducing this function to reduce code replication in multiple drivers. Signed-off-by: Kirti Wankhede Signed-off-by: Neo Jia Change-Id: Ie201f269dda0713ca18a07dc4852500bd8b48309 --- drivers/vfio/vfio.c | 39 +++++++++++++++++++++++++++++++++++++++ include/linux/vfio.h | 4 ++++ 2 files changed, 43 insertions(+) diff --git a/drivers/vfio/vfio.c b/drivers/vfio/vfio.c index e96cb3f7a23c..10ef1c5fa762 100644 --- a/drivers/vfio/vfio.c +++ b/drivers/vfio/vfio.c @@ -1877,6 +1877,45 @@ int vfio_info_add_capability(struct vfio_region_info *info, } EXPORT_SYMBOL(vfio_info_add_capability); +int vfio_set_irqs_validate_and_prepare(struct vfio_irq_set *hdr, int num_irqs, + int max_irq_type, size_t *data_size) +{ + unsigned long minsz; + + minsz = offsetofend(struct vfio_irq_set, count); + + if ((hdr->argsz < minsz) || (hdr->index >= max_irq_type) || + (hdr->flags & ~(VFIO_IRQ_SET_DATA_TYPE_MASK | + VFIO_IRQ_SET_ACTION_TYPE_MASK))) + return -EINVAL; + + if (data_size) + *data_size = 0; + + if (!(hdr->flags & VFIO_IRQ_SET_DATA_NONE)) { + size_t size; + + if (hdr->flags & VFIO_IRQ_SET_DATA_BOOL) + size = sizeof(uint8_t); + else if (hdr->flags & VFIO_IRQ_SET_DATA_EVENTFD) + size = sizeof(int32_t); + else + return -EINVAL; + + if ((hdr->argsz - minsz < hdr->count * size) || + (hdr->start >= num_irqs) || + (hdr->start + hdr->count > num_irqs)) + return -EINVAL; + + if (!data_size) + return -EINVAL; + + *data_size = hdr->count * size; + } + + return 0; +} +EXPORT_SYMBOL(vfio_set_irqs_validate_and_prepare); /* * Pin a set of guest PFNs and return their associated host PFNs for local diff --git a/include/linux/vfio.h b/include/linux/vfio.h index 854a4b40be02..31d059f1649b 100644 --- a/include/linux/vfio.h +++ b/include/linux/vfio.h @@ -112,6 +112,10 @@ extern int vfio_info_add_capability(struct vfio_region_info *info, struct vfio_info_cap *caps, int cap_type_id, void *cap_type); +extern int vfio_set_irqs_validate_and_prepare(struct vfio_irq_set *hdr, + int num_irqs, int max_irq_type, + size_t *data_size); + struct pci_dev; #ifdef CONFIG_EEH extern void vfio_spapr_pci_eeh_open(struct pci_dev *pdev); -- 2.7.0 From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55319) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bwFLk-0007Qh-7f for qemu-devel@nongnu.org; Mon, 17 Oct 2016 17:21:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bwFLf-00049z-VD for qemu-devel@nongnu.org; Mon, 17 Oct 2016 17:21:36 -0400 Received: from hqemgate16.nvidia.com ([216.228.121.65]:1943) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1bwFLf-00048r-MH for qemu-devel@nongnu.org; Mon, 17 Oct 2016 17:21:31 -0400 From: Kirti Wankhede Date: Tue, 18 Oct 2016 02:52:07 +0530 Message-ID: <1476739332-4911-8-git-send-email-kwankhede@nvidia.com> In-Reply-To: <1476739332-4911-1-git-send-email-kwankhede@nvidia.com> References: <1476739332-4911-1-git-send-email-kwankhede@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain Subject: [Qemu-devel] [PATCH v9 07/12] vfio: Introduce vfio_set_irqs_validate_and_prepare() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: alex.williamson@redhat.com, pbonzini@redhat.com, kraxel@redhat.com, cjia@nvidia.com Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org, kevin.tian@intel.com, jike.song@intel.com, bjsdjshi@linux.vnet.ibm.com, linux-kernel@vger.kernel.org, Kirti Wankhede Vendor driver using mediated device framework would use same mechnism to validate and prepare IRQs. Introducing this function to reduce code replication in multiple drivers. Signed-off-by: Kirti Wankhede Signed-off-by: Neo Jia Change-Id: Ie201f269dda0713ca18a07dc4852500bd8b48309 --- drivers/vfio/vfio.c | 39 +++++++++++++++++++++++++++++++++++++++ include/linux/vfio.h | 4 ++++ 2 files changed, 43 insertions(+) diff --git a/drivers/vfio/vfio.c b/drivers/vfio/vfio.c index e96cb3f7a23c..10ef1c5fa762 100644 --- a/drivers/vfio/vfio.c +++ b/drivers/vfio/vfio.c @@ -1877,6 +1877,45 @@ int vfio_info_add_capability(struct vfio_region_info *info, } EXPORT_SYMBOL(vfio_info_add_capability); +int vfio_set_irqs_validate_and_prepare(struct vfio_irq_set *hdr, int num_irqs, + int max_irq_type, size_t *data_size) +{ + unsigned long minsz; + + minsz = offsetofend(struct vfio_irq_set, count); + + if ((hdr->argsz < minsz) || (hdr->index >= max_irq_type) || + (hdr->flags & ~(VFIO_IRQ_SET_DATA_TYPE_MASK | + VFIO_IRQ_SET_ACTION_TYPE_MASK))) + return -EINVAL; + + if (data_size) + *data_size = 0; + + if (!(hdr->flags & VFIO_IRQ_SET_DATA_NONE)) { + size_t size; + + if (hdr->flags & VFIO_IRQ_SET_DATA_BOOL) + size = sizeof(uint8_t); + else if (hdr->flags & VFIO_IRQ_SET_DATA_EVENTFD) + size = sizeof(int32_t); + else + return -EINVAL; + + if ((hdr->argsz - minsz < hdr->count * size) || + (hdr->start >= num_irqs) || + (hdr->start + hdr->count > num_irqs)) + return -EINVAL; + + if (!data_size) + return -EINVAL; + + *data_size = hdr->count * size; + } + + return 0; +} +EXPORT_SYMBOL(vfio_set_irqs_validate_and_prepare); /* * Pin a set of guest PFNs and return their associated host PFNs for local diff --git a/include/linux/vfio.h b/include/linux/vfio.h index 854a4b40be02..31d059f1649b 100644 --- a/include/linux/vfio.h +++ b/include/linux/vfio.h @@ -112,6 +112,10 @@ extern int vfio_info_add_capability(struct vfio_region_info *info, struct vfio_info_cap *caps, int cap_type_id, void *cap_type); +extern int vfio_set_irqs_validate_and_prepare(struct vfio_irq_set *hdr, + int num_irqs, int max_irq_type, + size_t *data_size); + struct pci_dev; #ifdef CONFIG_EEH extern void vfio_spapr_pci_eeh_open(struct pci_dev *pdev); -- 2.7.0