From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mail.openembedded.org (Postfix) with ESMTP id B9F877198E for ; Tue, 18 Oct 2016 16:39:36 +0000 (UTC) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga102.fm.intel.com with ESMTP; 18 Oct 2016 09:39:38 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,362,1473145200"; d="scan'208,217";a="774151460" Received: from jlock-mobl1.ld.intel.com ([10.103.239.41]) by FMSMGA003.fm.intel.com with ESMTP; 18 Oct 2016 09:39:36 -0700 Message-ID: <1476808775.14120.7.camel@linux.intel.com> From: Joshua Lock To: Leonardo Sandoval , "Burton, Ross" Date: Tue, 18 Oct 2016 17:39:35 +0100 In-Reply-To: References: <5458be631bd0e452a6b05b09e9b86d6fbf567eeb.1476462963.git.leonardo.sandoval.gonzalez@linux.intel.com> X-Mailer: Evolution 3.20.5 (3.20.5-1.fc24) Mime-Version: 1.0 Cc: OE-core Subject: Re: [PATCH 4/9] selftest: skip some devtool tests when distro is poky-tiny due to missing libx11 X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Oct 2016 16:39:36 -0000 Content-Type: multipart/alternative; boundary="=-CcXkrkmsiNQYd5UoLSla" --=-CcXkrkmsiNQYd5UoLSla Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit On Mon, 2016-10-17 at 10:19 -0500, Leonardo Sandoval wrote: > >      > >      >      > >     On 10/17/2016 06:42 AM, Burton, Ross >       wrote: > >      > > >        > >          > > > > > >           On 14 October 2016 at 17:40, > >             wrote: > > > > >                   > > >                  def test_devtool_add_fetch_git(self): > > > > > >                 -        # Fetch source > > > > > >                 +        if self.distro == 'poky-tiny': > > > > > >                 +            self.skipTest('libmatchbox2 is not > > > > > >                 buildable with poky-tiny because it requires a libx11 > > >                 provider') > > > > > > > > >                          tempdir = tempfile.mkdtemp(prefix='devtoolqa') > > > > > >                          self.track_for_cleanup(tempdir) > > > > > > > > >                          url = 'git://git.yoctoproject.org/libmatchbox' > > > > > >              > >            > > > >            > > > >           Changing the test to use a recipe that doesn't require a > > > >           distro feature that many distros disable seems like a more > >           sustainable fix. > > > >          > > > >          > > > >        > > >     Which recipe do you think would be more generic? Something in the minimal image which doesn't rely on DISTRO_FEATURES which aren't in the default distro. Thanks, Joshua --=-CcXkrkmsiNQYd5UoLSla Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit
On Mon, 2016-10-17 at 10:19 -0500, Leonardo Sandoval wrote:



On 10/17/2016 06:42 AM, Burton, Ross wrote:

On 14 October 2016 at 17:40, <leonardo.sandoval.gonzalez@linux.intel.com> wrote:
     def test_devtool_add_fetch_git(self):
-        # Fetch source
+        if self.distro == 'poky-tiny':
+            self.skipTest('libmatchbox2 is not buildable with poky-tiny because it requires a libx11 provider')
         tempdir = tempfile.mkdtemp(prefix='devtoolqa')
         self.track_for_cleanup(tempdir)
         url = 'git://git.yoctoproject.org/libmatchbox'


Changing the test to use a recipe that doesn't require a distro feature that many distros disable seems like a more sustainable fix.

Which recipe do you think would be more generic?

Something in the minimal image which doesn't rely on DISTRO_FEATURES which aren't in the default distro.

Thanks,

Joshua
--=-CcXkrkmsiNQYd5UoLSla--