From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexey.Brodkin@synopsys.com (Alexey Brodkin) Date: Wed, 19 Oct 2016 09:32:38 +0000 Subject: [PATCH v2] drm/arcpgu: Accommodate adv7511 switch to DRM bridge In-Reply-To: <26a8cad6-118f-146f-f6ea-e9d539fc40a1@codeaurora.org> References: <1476863178-15237-1-git-send-email-Eugeniy.Paltsev@synopsys.com> <26a8cad6-118f-146f-f6ea-e9d539fc40a1@codeaurora.org> List-ID: Message-ID: <1476869529.3348.27.camel@synopsys.com> To: linux-snps-arc@lists.infradead.org Hi Archit, all, On Wed, 2016-10-19@14:43 +0530, Archit Taneja wrote: > > On 10/19/2016 01:16 PM, Eugeniy Paltsev wrote: > > > > ARC PGU driver starts crashing on initialization after > > 'commit e12c2f645557 ("drm/i2c: adv7511: Convert to drm_bridge")' > > This happenes because in "arcpgu_drm_hdmi_init" function we get pointer > > of "drm_i2c_encoder_driver" structure, which doesn't exist after > > adv7511 hdmi encoder interface changed from slave encoder to drm bridge. > > So, when we call "encoder_init" function from this structure driver > > crashes. [snip] > Looks good now. > > Reviewed-by: Archit Taneja And IMHO it would be really good to get this one back-ported to 4.8 because it really fixes kernel crash if ARC PGU driver is used. It might be a bit of a problem because patch itself a little-bit larger than formal requirement for stable backports but let's see if it gets accepted. -Alexey From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexey Brodkin Subject: Re: [PATCH v2] drm/arcpgu: Accommodate adv7511 switch to DRM bridge Date: Wed, 19 Oct 2016 09:32:38 +0000 Message-ID: <1476869529.3348.27.camel@synopsys.com> References: <1476863178-15237-1-git-send-email-Eugeniy.Paltsev@synopsys.com> <26a8cad6-118f-146f-f6ea-e9d539fc40a1@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <26a8cad6-118f-146f-f6ea-e9d539fc40a1@codeaurora.org> Content-Language: en-US Content-ID: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-snps-arc" Errors-To: linux-snps-arc-bounces+gla-linux-snps-arc=m.gmane.org@lists.infradead.org To: "dri-devel@lists.freedesktop.org" , "architt@codeaurora.org" , "Eugeniy.Paltsev@synopsys.com" Cc: "linux-snps-arc@lists.infradead.org" , "linux-kernel@vger.kernel.org" List-Id: dri-devel@lists.freedesktop.org Hi Archit, all, On Wed, 2016-10-19 at 14:43 +0530, Archit Taneja wrote: > > On 10/19/2016 01:16 PM, Eugeniy Paltsev wrote: > > > > ARC PGU driver starts crashing on initialization after > > 'commit e12c2f645557 ("drm/i2c: adv7511: Convert to drm_bridge")' > > This happenes because in "arcpgu_drm_hdmi_init" function we get pointer > > of "drm_i2c_encoder_driver" structure, which doesn't exist after > > adv7511 hdmi encoder interface changed from slave encoder to drm bridge. > > So, when we call "encoder_init" function from this structure driver > > crashes. [snip] > Looks good now. > > Reviewed-by: Archit Taneja And IMHO it would be really good to get this one back-ported to 4.8 because it really fixes kernel crash if ARC PGU driver is used. It might be a bit of a problem because patch itself a little-bit larger than formal requirement for stable backports but let's see if it gets accepted. -Alexey From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S941770AbcJSOVd (ORCPT ); Wed, 19 Oct 2016 10:21:33 -0400 Received: from us01smtprelay-2.synopsys.com ([198.182.60.111]:41328 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S941142AbcJSOVY (ORCPT ); Wed, 19 Oct 2016 10:21:24 -0400 From: Alexey Brodkin To: "dri-devel@lists.freedesktop.org" , "architt@codeaurora.org" , "Eugeniy.Paltsev@synopsys.com" CC: "linux-kernel@vger.kernel.org" , "linux-snps-arc@lists.infradead.org" Subject: Re: [PATCH v2] drm/arcpgu: Accommodate adv7511 switch to DRM bridge Thread-Topic: [PATCH v2] drm/arcpgu: Accommodate adv7511 switch to DRM bridge Thread-Index: AQHSKdzlNgYQRNBwDkuafqtoQBvjQKCvXP+AgAAFE4A= Date: Wed, 19 Oct 2016 09:32:38 +0000 Message-ID: <1476869529.3348.27.camel@synopsys.com> References: <1476863178-15237-1-git-send-email-Eugeniy.Paltsev@synopsys.com> <26a8cad6-118f-146f-f6ea-e9d539fc40a1@codeaurora.org> In-Reply-To: <26a8cad6-118f-146f-f6ea-e9d539fc40a1@codeaurora.org> Accept-Language: en-US, ru-RU Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.121.14.110] Content-Type: text/plain; charset="utf-8" Content-ID: MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id u9JELiIJ016618 Hi Archit, all, On Wed, 2016-10-19 at 14:43 +0530, Archit Taneja wrote: > > On 10/19/2016 01:16 PM, Eugeniy Paltsev wrote: > > > > ARC PGU driver starts crashing on initialization after > > 'commit e12c2f645557 ("drm/i2c: adv7511: Convert to drm_bridge")' > > This happenes because in "arcpgu_drm_hdmi_init" function we get pointer > > of "drm_i2c_encoder_driver" structure, which doesn't exist after > > adv7511 hdmi encoder interface changed from slave encoder to drm bridge. > > So, when we call "encoder_init" function from this structure driver > > crashes. [snip] > Looks good now. > > Reviewed-by: Archit Taneja And IMHO it would be really good to get this one back-ported to 4.8 because it really fixes kernel crash if ARC PGU driver is used. It might be a bit of a problem because patch itself a little-bit larger than formal requirement for stable backports but let's see if it gets accepted. -Alexey