All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Pandruvada, Srinivas" <srinivas.pandruvada@intel.com>
To: "jikos@kernel.org" <jikos@kernel.org>,
	"Ooi, Joyce" <joyce.ooi@intel.com>
Cc: "linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
	"Ong, Boon Leong" <boon.leong.ong@intel.com>,
	"Xu, Even" <even.xu@intel.com>,
	"Kweh, Hock Leong" <hock.leong.kweh@intel.com>
Subject: Re: [PATCH 3/4] hid: intel-ish-hid: ipc: Fix driver reinit failure
Date: Wed, 19 Oct 2016 12:43:09 +0000	[thread overview]
Message-ID: <1476880987.3261.1.camel@intel.com> (raw)
In-Reply-To: <D53702B8F0ACD34B9B1D7D82EE03C04501273950@PGSMSX101.gar.corp.intel.com>

On Wed, 2016-10-19 at 09:58 +0000, Ooi, Joyce wrote:

[...]

> > +	/* Put ISH to D3 state for power saving */
> > +	pci_read_config_word(pdev, pdev->pm_cap + PCI_PM_CTRL,
> > &csr);
> > +
> > +	csr &= ~PCI_PM_CTRL_STATE_MASK;
> > +	csr |= PCI_D3hot;
> > +	pci_write_config_word(pdev, pdev->pm_cap + PCI_PM_CTRL,
> > csr);
> > +
> 
> Do you think it would be cleaner if we use pci_set_power_state() ?
> http://lxr.free-electrons.com/source/drivers/pci/pci.c#L877

Makes sense.
I will test and update this.

Thanks,
Srinivas

  reply	other threads:[~2016-10-19 14:10 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-15 16:22 [PATCH 0/4] intel-ish-hid: Fixes for loading failures Srinivas Pandruvada
2016-10-15 16:22 ` [PATCH 1/4] hid: intel-ish-hid: ipc: consolidate ish wake up operation Srinivas Pandruvada
2016-10-15 16:22 ` [PATCH 2/4] hid: intel-ish-hid: ipc: Move DMA disable code to new function Srinivas Pandruvada
2016-10-15 16:22 ` [PATCH 3/4] hid: intel-ish-hid: ipc: Fix driver reinit failure Srinivas Pandruvada
     [not found]   ` <9577C59DB499174B9340876B077C2E9566FF6E12@SHSMSX101.ccr.corp.intel.com>
2016-10-19  9:58     ` Ooi, Joyce
2016-10-19 12:43       ` Pandruvada, Srinivas [this message]
2016-10-15 16:22 ` [PATCH 4/4] hid: intel-ish-hid: request_irq failure Srinivas Pandruvada

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1476880987.3261.1.camel@intel.com \
    --to=srinivas.pandruvada@intel.com \
    --cc=boon.leong.ong@intel.com \
    --cc=even.xu@intel.com \
    --cc=hock.leong.kweh@intel.com \
    --cc=jikos@kernel.org \
    --cc=joyce.ooi@intel.com \
    --cc=linux-input@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.