From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33335) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bxDes-0006X9-3y for qemu-devel@nongnu.org; Thu, 20 Oct 2016 09:45:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bxDer-00041n-8m for qemu-devel@nongnu.org; Thu, 20 Oct 2016 09:45:22 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60118) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1bxDer-00041X-2g for qemu-devel@nongnu.org; Thu, 20 Oct 2016 09:45:21 -0400 From: "Daniel P. Berrange" Date: Thu, 20 Oct 2016 14:45:07 +0100 Message-Id: <1476971110-10403-4-git-send-email-berrange@redhat.com> In-Reply-To: <1476971110-10403-1-git-send-email-berrange@redhat.com> References: <1476971110-10403-1-git-send-email-berrange@redhat.com> Subject: [Qemu-devel] [PULL v1 3/6] crypto: add mode check in qcrypto_cipher_new() for cipher-builtin List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Peter Maydell , Gonglei , "Daniel P . Berrange" From: Gonglei Signed-off-by: Gonglei Signed-off-by: Daniel P. Berrange --- crypto/cipher-builtin.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/crypto/cipher-builtin.c b/crypto/cipher-builtin.c index fd59a9e..b4bc2b9 100644 --- a/crypto/cipher-builtin.c +++ b/crypto/cipher-builtin.c @@ -433,6 +433,17 @@ QCryptoCipher *qcrypto_cipher_new(QCryptoCipherAlgorithm alg, { QCryptoCipher *cipher; + switch (mode) { + case QCRYPTO_CIPHER_MODE_ECB: + case QCRYPTO_CIPHER_MODE_CBC: + case QCRYPTO_CIPHER_MODE_XTS: + break; + default: + error_setg(errp, "Unsupported cipher mode %s", + QCryptoCipherMode_lookup[mode]); + return NULL; + } + cipher = g_new0(QCryptoCipher, 1); cipher->alg = alg; cipher->mode = mode; -- 2.7.4