diff for duplicates of <1476976532.3002.6.camel@linux.intel.com> diff --git a/a/1.txt b/N1/1.txt index 2fb158c..30e1c26 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -3,14 +3,14 @@ On ke, 2016-10-19 at 20:41 +0530, akash goel wrote: > > <joonas.lahtinen@linux.intel.com> wrote: > > On ke, 2016-03-23 at 11:39 +0530, akash.goel@intel.com wrote: > > > @@ -34,11 +34,28 @@ struct shmem_sb_info { -> > > struct mempolicy *mpol; /* default memory policy for mappings */ -> > > }; +> > > A A A A A A struct mempolicy *mpol;A A A A A /* default memory policy for mappings */ +> > > A }; > > > > > > +struct shmem_dev_info { -> > > + void *dev_private_data; -> > > + int (*dev_migratepage)(struct address_space *mapping, -> > > + struct page *newpage, struct page *page, -> > > + enum migrate_mode mode, void *dev_priv_data); +> > > +A A A A A void *dev_private_data; +> > > +A A A A A int (*dev_migratepage)(struct address_space *mapping, +> > > +A A A A A A A A A A A A A A A A A A A A A A A A A A A A struct page *newpage, struct page *page, +> > > +A A A A A A A A A A A A A A A A A A A A A A A A A A A A enum migrate_mode mode, void *dev_priv_data); > > > > One might want to have a separate shmem_dev_operations struct or > > similar. @@ -29,27 +29,27 @@ might be in order, too. I should be obvious from context. > > > +}; > > > + -> > > static inline struct shmem_inode_info *SHMEM_I(struct inode *inode) -> > > { -> > > return container_of(inode, struct shmem_inode_info, vfs_inode); -> > > } +> > > A static inline struct shmem_inode_info *SHMEM_I(struct inode *inode) +> > > A { +> > > A A A A A A return container_of(inode, struct shmem_inode_info, vfs_inode); +> > > A } > > > > > > +static inline int shmem_set_device_ops(struct address_space *mapping, -> > > + struct shmem_dev_info *info) +> > > +A A A A A A A A A A A A A A A A A A A A A A A A A A A A A struct shmem_dev_info *info) > > > +{ This name could be shmem_set_dev_info, if there will be separate _ops struct in future. -> > > + if (mapping->private_data != NULL) -> > > + return -EEXIST; +> > > +A A A A A if (mapping->private_data != NULL) +> > > +A A A A A A A A A A A A A return -EEXIST; > > > + > > > > I did a quick random peek and most set functions are just void and > > override existing data. I'd suggest the same. > > > > > -> > > + mapping->private_data = info; +> > > +A A A A A mapping->private_data = info; > > > Fine will change the return type to void and remove the check. > @@ -70,7 +70,9 @@ Regards, Joonas Joonas Lahtinen Open Source Technology Center Intel Corporation -_______________________________________________ -Intel-gfx mailing list -Intel-gfx@lists.freedesktop.org -https://lists.freedesktop.org/mailman/listinfo/intel-gfx + +-- +To unsubscribe, send a message with 'unsubscribe linux-mm' in +the body to majordomo@kvack.org. For more info on Linux MM, +see: http://www.linux-mm.org/ . +Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a> diff --git a/a/content_digest b/N1/content_digest index 9a831ba..88b3451 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -2,16 +2,16 @@ "ref\01458821494.7860.9.camel@linux.intel.com\0" "ref\0CAK_0AV3KKVZOr6WRtFOox-WKQ0wR34ry-hnR=O7aMX8DhgcGhA@mail.gmail.com\0" "From\0Joonas Lahtinen <joonas.lahtinen@linux.intel.com>\0" - "Subject\0Re: [PATCH 1/2] shmem: Support for registration of Driver/file owner specific ops\0" + "Subject\0Re: [Intel-gfx] [PATCH 1/2] shmem: Support for registration of Driver/file owner specific ops\0" "Date\0Thu, 20 Oct 2016 18:15:32 +0300\0" "To\0akash goel <akash.goels@gmail.com>" " Chris Wilson <chris@chris-wilson.co.uk>\0" - "Cc\0Goel" - Akash <akash.goel@intel.com> + "Cc\0intel-gfx@lists.freedesktop.org" linux-mm@kvack.org - intel-gfx@lists.freedesktop.org Hugh Dickins <hughd@google.com> - " Sourab Gupta <sourab.gupta@intel.com>\0" + Sourab Gupta <sourab.gupta@intel.com> + Goel + " Akash <akash.goel@intel.com>\0" "\00:1\0" "b\0" "On ke, 2016-10-19 at 20:41 +0530, akash goel wrote:\n" @@ -19,14 +19,14 @@ "> > <joonas.lahtinen@linux.intel.com> wrote:\n" "> > On ke, 2016-03-23 at 11:39 +0530, akash.goel@intel.com wrote:\n" "> > > @@ -34,11 +34,28 @@ struct shmem_sb_info {\n" - "> > > \302\240\302\240\302\240\302\240\302\240\302\240struct mempolicy *mpol;\302\240\302\240\302\240\302\240\302\240/* default memory policy for mappings */\n" - "> > > \302\240};\n" + "> > > A A A A A A struct mempolicy *mpol;A A A A A /* default memory policy for mappings */\n" + "> > > A };\n" "> > > \n" "> > > +struct shmem_dev_info {\n" - "> > > +\302\240\302\240\302\240\302\240\302\240void *dev_private_data;\n" - "> > > +\302\240\302\240\302\240\302\240\302\240int (*dev_migratepage)(struct address_space *mapping,\n" - "> > > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240struct page *newpage, struct page *page,\n" - "> > > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240enum migrate_mode mode, void *dev_priv_data);\n" + "> > > +A A A A A void *dev_private_data;\n" + "> > > +A A A A A int (*dev_migratepage)(struct address_space *mapping,\n" + "> > > +A A A A A A A A A A A A A A A A A A A A A A A A A A A A struct page *newpage, struct page *page,\n" + "> > > +A A A A A A A A A A A A A A A A A A A A A A A A A A A A enum migrate_mode mode, void *dev_priv_data);\n" "> > \n" "> > One might want to have a separate shmem_dev_operations struct or\n" "> > similar.\n" @@ -45,27 +45,27 @@ "\n" "> > > +};\n" "> > > +\n" - "> > > \302\240static inline struct shmem_inode_info *SHMEM_I(struct inode *inode)\n" - "> > > \302\240{\n" - "> > > \302\240\302\240\302\240\302\240\302\240\302\240return container_of(inode, struct shmem_inode_info, vfs_inode);\n" - "> > > \302\240}\n" + "> > > A static inline struct shmem_inode_info *SHMEM_I(struct inode *inode)\n" + "> > > A {\n" + "> > > A A A A A A return container_of(inode, struct shmem_inode_info, vfs_inode);\n" + "> > > A }\n" "> > > \n" "> > > +static inline int shmem_set_device_ops(struct address_space *mapping,\n" - "> > > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240struct shmem_dev_info *info)\n" + "> > > +A A A A A A A A A A A A A A A A A A A A A A A A A A A A A struct shmem_dev_info *info)\n" "> > > +{\n" "\n" "This name could be shmem_set_dev_info, if there will be separate _ops\n" "struct in future.\n" "\n" - "> > > +\302\240\302\240\302\240\302\240\302\240if (mapping->private_data != NULL)\n" - "> > > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240return -EEXIST;\n" + "> > > +A A A A A if (mapping->private_data != NULL)\n" + "> > > +A A A A A A A A A A A A A return -EEXIST;\n" "> > > +\n" "> > \n" "> > I did a quick random peek and most set functions are just void and\n" "> > override existing data. I'd suggest the same.\n" "> > \n" "> > > \n" - "> > > +\302\240\302\240\302\240\302\240\302\240mapping->private_data = info;\n" + "> > > +A A A A A mapping->private_data = info;\n" "> > \n" "> Fine will change the return type to void and remove the check.\n" "> \n" @@ -86,9 +86,11 @@ "Joonas Lahtinen\n" "Open Source Technology Center\n" "Intel Corporation\n" - "_______________________________________________\n" - "Intel-gfx mailing list\n" - "Intel-gfx@lists.freedesktop.org\n" - https://lists.freedesktop.org/mailman/listinfo/intel-gfx + "\n" + "--\n" + "To unsubscribe, send a message with 'unsubscribe linux-mm' in\n" + "the body to majordomo@kvack.org. For more info on Linux MM,\n" + "see: http://www.linux-mm.org/ .\n" + "Don't email: <a href=mailto:\"dont@kvack.org\"> email@kvack.org </a>" -ca315f0b247173a9e3b3748858ddccdc7a2ac341c605798ce3065f68763d2ea9 +41a4042a9825618275903bc2eae17a3ec93125b3e0c4877b88a110db2baa6690
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.