From: Dennis Kaarsemaker <dennis@kaarsemaker.net>
To: Jacob Keller <jacob.e.keller@intel.com>, git@vger.kernel.org
Cc: Junio C Hamano <gitster@pobox.com>,
Jacob Keller <jacob.keller@gmail.com>
Subject: Re: [PATCH] rev-list: use hdr_termination instead of a always using a newline
Date: Thu, 20 Oct 2016 20:49:40 +0200 [thread overview]
Message-ID: <1476989380.28685.8.camel@kaarsemaker.net> (raw)
In-Reply-To: <20161020181930.21084-1-jacob.e.keller@intel.com>
On Thu, 2016-10-20 at 11:19 -0700, Jacob Keller wrote:
> Here's my solution, with an updated test using a helper function based
> on using sed (which I think is more portable than tail -n1 ?). The
> change actually is very simple. I ran the test suite and it appears to
> be not breaking anyone else since the normal case is
> hdr_termination="\n" except in the cases where it needs to be NUL.
>
> Thanks for the bug report!
I like both improvements, and both 'make test' and gitweb are happy
with this version. Thanks for the quick fix.
D.
next prev parent reply other threads:[~2016-10-20 18:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-20 18:19 [PATCH] rev-list: use hdr_termination instead of a always using a newline Jacob Keller
2016-10-20 18:49 ` Dennis Kaarsemaker [this message]
2016-10-20 18:54 ` Junio C Hamano
2016-10-20 20:05 ` Jacob Keller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1476989380.28685.8.camel@kaarsemaker.net \
--to=dennis@kaarsemaker.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jacob.e.keller@intel.com \
--cc=jacob.keller@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.