diff for duplicates of <1477040798.15560.96.camel@baylibre.com> diff --git a/a/1.txt b/N1/1.txt index 4314933..5387dda 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -14,27 +14,27 @@ On Thu, 2016-10-20 at 21:21 +0200, Linus Walleij wrote: > > Signed-off-by: Jerome Brunet <jbrunet@baylibre.com> > (...) > > -> > +???????select IRQ_DOMAIN -> > ????????select OF_GPIO -> > +???????select OF_IRQ +> > + select IRQ_DOMAIN +> > select OF_GPIO +> > + select OF_IRQ > (...) > > > > +static int meson_gpio_to_hwirq(struct meson_bank *bank, unsigned > > int offset) > > +{ -> > +???????unsigned int hwirq; +> > + unsigned int hwirq; > > + -> > +???????if (bank->irq_first < 0) -> > +???????????????/* this bank cannot generate irqs */ -> > +???????????????return -1; +> > + if (bank->irq_first < 0) +> > + /* this bank cannot generate irqs */ +> > + return -1; > > + -> > +???????hwirq = offset - bank->first + bank->irq_first; +> > + hwirq = offset - bank->first + bank->irq_first; > > + -> > +???????if (hwirq > bank->irq_last) -> > +???????????????/* this pin cannot generate irqs */ -> > +???????????????return -1; +> > + if (hwirq > bank->irq_last) +> > + /* this pin cannot generate irqs */ +> > + return -1; > > + -> > +???????return hwirq; +> > + return hwirq; > > +} > > This is reimplementing irqdomain. @@ -45,12 +45,12 @@ On Thu, 2016-10-20 at 21:21 +0200, Linus Walleij wrote: > > +{ > (...) > > -> > +???????hwirq = meson_gpio_to_hwirq(bank, offset); -> > +???????if (hwirq < 0) { -> > +???????????????dev_dbg(pc->dev, "no interrupt for pin %u\n", +> > + hwirq = meson_gpio_to_hwirq(bank, offset); +> > + if (hwirq < 0) { +> > + dev_dbg(pc->dev, "no interrupt for pin %u\n", > > offset); -> > +???????????????return 0; -> > +???????} +> > + return 0; +> > + } > > Isn't this usecase (also as described in the cover letter) a textbook > example of when you should be using hierarchical irqdomain? @@ -58,7 +58,7 @@ On Thu, 2016-10-20 at 21:21 +0200, Linus Walleij wrote: > Please check with Marc et al on hierarchical irqdomains. Linus, -Do you mean I should create a new hierarchical?irqdomains in each of +Do you mean I should create a new hierarchical irqdomains in each of the two pinctrl instances we have in these SoC, these domains being stacked on the one I just added for controller in irqchip ? diff --git a/a/content_digest b/N1/content_digest index 6e5f0e7..5f1d3b9 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,10 +1,24 @@ "ref\01476871709-8359-1-git-send-email-jbrunet@baylibre.com\0" "ref\01476871709-8359-5-git-send-email-jbrunet@baylibre.com\0" "ref\0CACRpkdaCZPS45t3eTcjJExOu=YT_YkjNkdpg09jQqvLQOJH=Qw@mail.gmail.com\0" - "From\0jbrunet@baylibre.com (Jerome Brunet)\0" - "Subject\0[PATCH 4/9] pinctrl: meson: allow gpio to request irq\0" + "From\0Jerome Brunet <jbrunet@baylibre.com>\0" + "Subject\0Re: [PATCH 4/9] pinctrl: meson: allow gpio to request irq\0" "Date\0Fri, 21 Oct 2016 11:06:38 +0200\0" - "To\0linus-amlogic@lists.infradead.org\0" + "To\0Linus Walleij <linus.walleij@linaro.org>\0" + "Cc\0Carlo Caione <carlo@caione.org>" + Kevin Hilman <khilman@baylibre.com> + open list:ARM/Amlogic Meson... <linux-amlogic@lists.infradead.org> + linux-arm-kernel@lists.infradead.org <linux-arm-kernel@lists.infradead.org> + linux-gpio@vger.kernel.org <linux-gpio@vger.kernel.org> + linux-kernel@vger.kernel.org <linux-kernel@vger.kernel.org> + devicetree@vger.kernel.org <devicetree@vger.kernel.org> + Thomas Gleixner <tglx@linutronix.de> + Jason Cooper <jason@lakedaemon.net> + Marc Zyngier <marc.zyngier@arm.com> + Rob Herring <robh+dt@kernel.org> + Catalin Marinas <catalin.marinas@arm.com> + Will Deacon <will.deacon@arm.com> + " Russell King <linux@armlinux.org.uk>\0" "\00:1\0" "b\0" "On Thu, 2016-10-20 at 21:21 +0200, Linus Walleij wrote:\n" @@ -23,27 +37,27 @@ "> > Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>\n" "> (...)\n" "> > \n" - "> > +???????select IRQ_DOMAIN\n" - "> > ????????select OF_GPIO\n" - "> > +???????select OF_IRQ\n" + "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240select IRQ_DOMAIN\n" + "> > \302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240select OF_GPIO\n" + "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240select OF_IRQ\n" "> (...)\n" "> > \n" "> > +static int meson_gpio_to_hwirq(struct meson_bank *bank, unsigned\n" "> > int offset)\n" "> > +{\n" - "> > +???????unsigned int hwirq;\n" + "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240unsigned int hwirq;\n" "> > +\n" - "> > +???????if (bank->irq_first < 0)\n" - "> > +???????????????/* this bank cannot generate irqs */\n" - "> > +???????????????return -1;\n" + "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240if (bank->irq_first < 0)\n" + "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240/* this bank cannot generate irqs */\n" + "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240return -1;\n" "> > +\n" - "> > +???????hwirq = offset - bank->first + bank->irq_first;\n" + "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240hwirq = offset - bank->first + bank->irq_first;\n" "> > +\n" - "> > +???????if (hwirq > bank->irq_last)\n" - "> > +???????????????/* this pin cannot generate irqs */\n" - "> > +???????????????return -1;\n" + "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240if (hwirq > bank->irq_last)\n" + "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240/* this pin cannot generate irqs */\n" + "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240return -1;\n" "> > +\n" - "> > +???????return hwirq;\n" + "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240return hwirq;\n" "> > +}\n" "> \n" "> This is reimplementing irqdomain.\n" @@ -54,12 +68,12 @@ "> > +{\n" "> (...)\n" "> > \n" - "> > +???????hwirq = meson_gpio_to_hwirq(bank, offset);\n" - "> > +???????if (hwirq < 0) {\n" - "> > +???????????????dev_dbg(pc->dev, \"no interrupt for pin %u\\n\",\n" + "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240hwirq = meson_gpio_to_hwirq(bank, offset);\n" + "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240if (hwirq < 0) {\n" + "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240dev_dbg(pc->dev, \"no interrupt for pin %u\\n\",\n" "> > offset);\n" - "> > +???????????????return 0;\n" - "> > +???????}\n" + "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240return 0;\n" + "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240}\n" "> \n" "> Isn't this usecase (also as described in the cover letter) a textbook\n" "> example of when you should be using hierarchical irqdomain?\n" @@ -67,7 +81,7 @@ "> Please check with Marc et al on hierarchical irqdomains.\n" "\n" "Linus,\n" - "Do you mean I should create a new hierarchical?irqdomains in each of\n" + "Do you mean I should create a new hierarchical\302\240irqdomains in each of\n" "the two pinctrl instances we have in these SoC, these domains being\n" "stacked on the one I just added for controller in irqchip ?\n" "\n" @@ -78,4 +92,4 @@ "> Yours,\n" > Linus Walleij -248d1058e9b5138a4aefa713d9646f8a7db4239dbb58fda366233d9965154ad7 +d496545a0b44a80e99c6c166f24106901d39843832cfef377f1a0d3531154053
diff --git a/a/content_digest b/N2/content_digest index 6e5f0e7..bc925bf 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -4,7 +4,7 @@ "From\0jbrunet@baylibre.com (Jerome Brunet)\0" "Subject\0[PATCH 4/9] pinctrl: meson: allow gpio to request irq\0" "Date\0Fri, 21 Oct 2016 11:06:38 +0200\0" - "To\0linus-amlogic@lists.infradead.org\0" + "To\0linux-arm-kernel@lists.infradead.org\0" "\00:1\0" "b\0" "On Thu, 2016-10-20 at 21:21 +0200, Linus Walleij wrote:\n" @@ -78,4 +78,4 @@ "> Yours,\n" > Linus Walleij -248d1058e9b5138a4aefa713d9646f8a7db4239dbb58fda366233d9965154ad7 +b0beb73ef2fe3031fbd2b3530e865d8a1b16e0f003ee2b17b5a944373b80e9db
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.