From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dario Faggioli <dario.faggioli@citrix.com>
Subject: Re: [PATCH v2] libxl: initialise nr_dom_vcpus to fix
	4a6070ea9
Date: Mon, 24 Oct 2016 12:22:28 +0200
Message-ID: <1477304548.27407.1.camel@citrix.com>
References: <1477303875-4017-1-git-send-email-wei.liu2@citrix.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============7599838732577495850=="
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta5.messagelabs.com ([195.245.231.135])
 by lists.xenproject.org with esmtp (Exim 4.84_2)
 (envelope-from <prvs=0983a48fc=dario.faggioli@citrix.com>)
 id 1bycOr-00020Y-OE
 for xen-devel@lists.xenproject.org; Mon, 24 Oct 2016 10:22:37 +0000
In-Reply-To: <1477303875-4017-1-git-send-email-wei.liu2@citrix.com>
List-Unsubscribe: <https://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <https://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xen.org
Sender: "Xen-devel" <xen-devel-bounces@lists.xen.org>
To: Wei Liu <wei.liu2@citrix.com>, Xen-devel <xen-devel@lists.xenproject.org>
Cc: Juergen Gross <jgross@suse.com>, Ian Jackson <ian.jackson@eu.citrix.com>
List-Id: xen-devel@lists.xenproject.org

--===============7599838732577495850==
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="=-smzzygQqaLtaIRQ/3/FR"

--=-smzzygQqaLtaIRQ/3/FR
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, 2016-10-24 at 11:11 +0100, Wei Liu wrote:
> Clang complains nr_dom_vcpus may be used uninitialised after
> 4a6070ea9.
>=20
> The real issue is vinfo can be NULL and nr_dom_vcpus remains
> uninitialised if previous call fails.
>=20
> Initialise nr_dom_vcpus to 0 at the beginning of the loop to fix the
> issue.
>=20
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>
>
Reviewed-by: Dario Faggioli <dario.faggioli@citrix.com>

Thanks and Regards,
Dario
--=20
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)
--=-smzzygQqaLtaIRQ/3/FR
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAABCAAGBQJYDeDmAAoJEBZCeImluHPuT7MP/RebIcdQe5OjLkRPenpbFXHB
AmFBLg/ghlUZFc+67bXJ6QOlKxLplH0ictAm2pN+vN0fMNEdNLrLC2QAkeqmaUSj
8h9eCOy1rZl70lqtZ2L9xZSInTOgftg4Dz7AsrXK/JeVdrZjMqU6ZtCX+eHAgJE4
PzSy688EZ3afhSR3oUWVv6Pd+nuUqVKs+H5wouklAR7dZ6VJZjwLbrhSZRUvyPWb
+DfOAi22fx5QlsNiOR3Ut8P1ZyNKhrbSF16s1CiAndwrCz4Bjc3gf40x8US94gxR
Hl8Fa1DPx+iWDsqCQESbsgrWJJnP6jLnCboR17X5Y93nfzKfmhaXoQGQJDkjN8Lj
J/FHLqNiyLH9hycOIo0QBb5ge9/+eSaCrd4/ad27dh820VGn5Dq28ybk58G4QuvB
auPOZG0CWxb/IfY4QUaU15hjnu6lb3gWyfln2M+abeZgEF8iKxa0+JJdn3xFiDUf
TBh44r1jnKqhKsEy7Vv7/RgS4DQ3bwgs69wwOWagUAgWZ25dbox/3wKTnSV562LH
UAPU1QRtrqtGktDlsSsOXn5DuI4SeDYYd7qz2Ej/OJGrWopxNL5AqUpVnohQaEJX
svZhB6gAQgiKSu3b3y1F1C257mQmPf4Hut80zDMROn9uyxkap+CnFpUZqR0G2rhg
NofHT1YTk9Vnv4bmlox2
=Lpgf
-----END PGP SIGNATURE-----

--=-smzzygQqaLtaIRQ/3/FR--


--===============7599838732577495850==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: base64
Content-Disposition: inline

X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs
IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwczovL2xpc3RzLnhlbi5v
cmcveGVuLWRldmVsCg==

--===============7599838732577495850==--