From: Michael Zoran <mzoran@crowfest.net>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
daniels@collabora.com, linux-kernel@vger.kernel.org,
eric@anholt.net, noralf@tronnes.org, popcornmix@gmail.com
Subject: Re: [PATCH 1/2] staging: vc04_services: Fix unportable cast in vchiq_copy_from_user
Date: Mon, 24 Oct 2016 04:39:49 -0700 [thread overview]
Message-ID: <1477309189.6666.6.camel@crowfest.net> (raw)
In-Reply-To: <20161024113601.GL4418@mwanda>
On Mon, 2016-10-24 at 14:36 +0300, Dan Carpenter wrote:
> On Mon, Oct 24, 2016 at 04:09:37AM -0700, Michael Zoran wrote:
> > I didn't think it looked totally correct, but I'm not sure it's any
> > more broken then what is already in the tree.
>
> It's not more broken. But better to leave the compile warning there
> to
> mark that it is an obvious security problem.
>
> >
> > If you can kindly point me to some other source code or
> > documentation
> > to look at that is correct, I'm more then willing to fix the patch.
> >
>
> I was hoping the maintainers could chip in, because I didn't want to
> look at the code. We really need to track which are use pointers and
> which are kernel pointers. We can't mix them like this.
>
> regards,
> dan carpenter
>
The problem is that I'm mostly interested in arm64 ATM, and I don't
think the existing code works at all with 64 bit pointers.
Broken as it may be...
next prev parent reply other threads:[~2016-10-24 11:49 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-24 5:29 [PATCH 1/2] staging: vc04_services: Fix unportable cast in vchiq_copy_from_user mzoran
2016-10-24 10:54 ` Dan Carpenter
2016-10-24 11:09 ` Michael Zoran
2016-10-24 11:36 ` Dan Carpenter
2016-10-24 11:39 ` Michael Zoran [this message]
2016-10-24 11:58 ` Dan Carpenter
2016-10-24 12:12 ` Michael Zoran
2016-10-24 12:30 ` Dan Carpenter
2016-10-24 13:23 ` Greg KH
2016-10-24 13:56 ` Michael Zoran
2016-10-24 14:46 ` Dan Carpenter
2016-10-24 15:13 ` Michael Zoran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1477309189.6666.6.camel@crowfest.net \
--to=mzoran@crowfest.net \
--cc=dan.carpenter@oracle.com \
--cc=daniels@collabora.com \
--cc=devel@driverdev.osuosl.org \
--cc=eric@anholt.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=noralf@tronnes.org \
--cc=popcornmix@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.