All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Luc, Piotr" <Piotr.Luc@intel.com>
To: "tglx@linutronix.de" <tglx@linutronix.de>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
	"mchehab@kernel.org" <mchehab@kernel.org>,
	"dougthompson@xmission.com" <dougthompson@xmission.com>,
	"x86@kernel.org" <x86@kernel.org>,
	"hpa@zytor.com" <hpa@zytor.com>,
	"viresh.kumar@linaro.org" <viresh.kumar@linaro.org>,
	"mingo@redhat.com" <mingo@redhat.com>,
	"rjw@rjwysocki.net" <rjw@rjwysocki.net>,
	"srinivas.pandruvada@linux.intel.com"
	<srinivas.pandruvada@linux.intel.com>,
	"bp@alien8.de" <bp@alien8.de>,
	"lenb@kernel.org" <lenb@kernel.org>,
	"linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>
Subject: Re: [PATCH v2 02/11] tools/power turbostat: Use Intel family processor macros
Date: Mon, 24 Oct 2016 13:15:25 +0000	[thread overview]
Message-ID: <1477314612.3927.11.camel@intel.com> (raw)
In-Reply-To: <alpine.DEB.2.20.1610141354090.11707@nanos>

On Fri, 2016-10-14 at 13:56 +0200, Thomas Gleixner wrote:
> On Thu, 13 Oct 2016, Piotr Luc wrote:

> > 
> > +	case INTEL_FAM6_SANDYBRIDGE:		/* SNB */
> 
> Especialy those, which are completely useless?
> 
> The defines are there to be self explaining and the extra verbose
> information should be in the header file defining the macros and not
> in the
> source code.

Hi

I submitted the turbostat patchset 
https://lkml.kernel.org/r/20161018210652.29365-1-piotr.luc@intel.com to
address the issues.

Regards
Piotr


  reply	other threads:[~2016-10-24 13:15 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-13 15:30 [RESEND PATCH 00/11] Add Knights Mill CPU ID Piotr Luc
2016-10-13 15:30 ` [RESEND PATCH 01/11] EDAC, sb_edac: Use Intel family processor macros Piotr Luc
2016-10-13 22:01   ` Borislav Petkov
2016-10-13 15:30 ` [PATCH v2 02/11] tools/power turbostat: " Piotr Luc
2016-10-14 11:56   ` Thomas Gleixner
2016-10-24 13:15     ` Luc, Piotr [this message]
2016-10-13 15:30 ` [RESEND PATCH 03/11] x86/cpu/intel: Add Knights Mill to Intel family Piotr Luc
2016-10-13 15:30 ` [RESEND PATCH 04/11] x86/intel_idle: Add Knights Mill CPUID Piotr Luc
2016-10-25 10:36   ` [RESEND,04/11] " Luc, Piotr
2016-12-01  5:29   ` [RESEND PATCH 04/11] " Len Brown
2016-12-01  8:45     ` Luc, Piotr
2016-10-13 15:30 ` [RESEND PATCH 05/11] EDAC, sb_edac: " Piotr Luc
2016-10-13 22:04   ` Borislav Petkov
2016-10-19 10:38     ` Borislav Petkov
2016-10-13 15:31 ` [RESEND PATCH 06/11] cpufreq: intel_pstate: " Piotr Luc
2016-10-13 17:51   ` Srinivas Pandruvada
2016-10-25 10:48     ` Luc, Piotr
2016-10-25 11:16       ` Rafael J. Wysocki
2016-10-25 11:44         ` Luc, Piotr
2016-11-30 16:19           ` Luc, Piotr
2016-11-30 22:01             ` Rafael J. Wysocki
2016-11-30 22:16               ` Luc, Piotr
2016-10-13 15:31 ` [RESEND PATCH 07/11] perf/x86/intel: " Piotr Luc
2016-10-13 15:31 ` [RESEND PATCH 08/11] perf/x86/intel/rapl: " Piotr Luc
2016-10-13 15:31 ` [RESEND PATCH 09/11] perf/x86/intel/uncore: " Piotr Luc
2016-10-13 15:31 ` [RESEND PATCH 10/11] powercap / RAPL: " Piotr Luc
2016-10-25 10:41   ` [RESEND,10/11] " Luc, Piotr
2016-11-30 22:33     ` Luc, Piotr
2016-11-30 22:42       ` Rafael J. Wysocki
2016-10-13 15:31 ` [RESEND PATCH 11/11] tools/power turbostat: enable turbostat to support Knights Mill (KNM) Piotr Luc
2016-12-01  6:47   ` Len Brown
2016-12-01 11:17     ` Luc, Piotr
2016-10-13 21:56 ` [RESEND PATCH 00/11] Add Knights Mill CPU ID Rafael J. Wysocki
2016-10-24 16:13   ` Luc, Piotr

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1477314612.3927.11.camel@intel.com \
    --to=piotr.luc@intel.com \
    --cc=bp@alien8.de \
    --cc=dougthompson@xmission.com \
    --cc=hpa@zytor.com \
    --cc=lenb@kernel.org \
    --cc=linux-edac@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=mingo@redhat.com \
    --cc=rjw@rjwysocki.net \
    --cc=srinivas.pandruvada@linux.intel.com \
    --cc=tglx@linutronix.de \
    --cc=viresh.kumar@linaro.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.