Re: [PATCH v3] cfg80211: Check radar_detect and num_different_channels with beacon interface combinations.

[Johannes Berg <johannes@sipsolutions.net>]

On Mon, 2016-10-24 at 11:59 +0000, Undekari, Sunil Dutt wrote:
> > 
> > I've just sent out a few patches that, I think, implement the
> > necessary validation for just the beacon intervals, without all
> > this extra baggage. Please take a look and let me know what you
> > think.
> I understand that the new patches from you are in consistent with the
> existing design of validating the radar detection / channels by
> having this validation done in the cfg80211 drivers through
> cfg80211_check_combinations.

Ok, so we agree here, that's good :)

> With this approach , wouldn't the existing cfg80211 drivers behave
> the other way ? I mean , with these commits and the current cfg80211
> drivers ( do not advertise beacon_int_min_gcd and invoke
> cfg80211_check_combinations) , the validation for the different
> beacon interval shall succeed , but the current kernel ( cfg80211
> interface ) with the same driver fails the start of the AP / mesh. 
> Is it not breaking the backward compatibility ? Is this expected ? 

Any driver that supports combinations should also invoke
check_combinations. This doesn't appear to be true for mwifiex, but
that's already a bug/problem in that driver, it doesn't really change
much?

johannes