From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50759)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1bzNGG-0007MG-E6
	for qemu-devel@nongnu.org; Wed, 26 Oct 2016 08:24:53 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1bzNGD-0004ic-Cl
	for qemu-devel@nongnu.org; Wed, 26 Oct 2016 08:24:52 -0400
Received: from mx1.redhat.com ([209.132.183.28]:59214)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <kraxel@redhat.com>) id 1bzNGD-0004iF-6w
	for qemu-devel@nongnu.org; Wed, 26 Oct 2016 08:24:49 -0400
Message-ID: <1477484686.18984.47.camel@redhat.com>
From: Gerd Hoffmann <kraxel@redhat.com>
Date: Wed, 26 Oct 2016 14:24:46 +0200
In-Reply-To: <20161026113552.GA2811@var.bordeaux.inria.fr>
References: <20161023195433.20102-1-samuel.thibault@ens-lyon.org>
	<20161023195433.20102-4-samuel.thibault@ens-lyon.org>
	<1477477064.18984.39.camel@redhat.com>
	<20161026113552.GA2811@var.bordeaux.inria.fr>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Mime-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 3/3] Move getting XWindow ID from baum
 driver to graphical backend
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Samuel Thibault <samuel.thibault@gnu.org>
Cc: qemu-devel@nongnu.org

> > Also splitting this up would be nice.
>=20
> You mean separating the move of the sdl1.2 code from the addition of
> sdl2+gtk code? (and perhaps separate sdl2 and gtk?)

One patch adding new console.[ch] interfaces, then one patch per UI,
finally switch over baum to the new interfaces.

Maybe put sdl-ui + baum into one patch as this moves existing code sdl
code from baum.c to sdl*.c for the most part.

> > No loop needed here.  qemu sorts consoles so the graphic ones come
> > first.
>=20
> Ok, but are we sure nobody will change that assumption someday?  Or do
> we assume that if somebody changes it he will notice the assumption in
> qemu_graphic_console_get_window_id?

If that assumption ever changes the code here (and in quite a few more
places) must be adapted to it.

cheers,
  Gerd