From: Johannes Berg <johannes@sipsolutions.net>
To: "Malinen, Jouni" <jouni@qca.qualcomm.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 2/8] mac80211: Allow AUTH_DATA to be used for FILS
Date: Wed, 26 Oct 2016 18:10:12 +0200 [thread overview]
Message-ID: <1477498212.5563.2.camel@sipsolutions.net> (raw)
In-Reply-To: <20161026153559.GA13254@jouni.qca.qualcomm.com>
> This is admittedly a bit strange design with that special case needed
> for SAE. If we were to design the SAE case now in combination with
> FILS, I guess this would be quite different (e.g., separate
> attributes for Authentication transaction sequence number and Status
> code). Unlike the mesh use case with SAE, FILS is only between an AP
> and a station and as such, there would not really be a case where the
> station would send an Authentication frame with non-zero Status code.
>
> A future amendment might define a new authentication algorithm that
> ends up using more than a single Authentication frame exchange. In
> such a case, we would actually have need for Authentication
> transaction sequence number even though FILS doesn't need it.
>
> I think I'd rather maintain a consistent attribute design for all
> authentication algorithms and leave this as-is now. Another option
> would be to not apply the rename SAE attributes patch and define
> something new as a more generic solution, but I'm not sure there is
> sufficient justification for the added complexity since we cannot
> really get rid of the current SAE design any time soon.
Yes, fair point.
Maybe you can clarify the nl80211 attribute documentation wrt. this? It
just states that it starts with the Authentication transaction sequence
field, but afaict that's not true, it also has the status code field,
which is also ignored here.
johannes
next prev parent reply other threads:[~2016-10-26 16:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-25 22:42 [PATCH 0/8] cfg80211/mac80211: Fast Initial Link Setup (IEEE 802.11ai) Jouni Malinen
2016-10-25 22:42 ` [PATCH 1/8] cfg80211: Rename SAE_DATA to more generic AUTH_DATA Jouni Malinen
2016-10-25 22:42 ` [PATCH 2/8] mac80211: Allow AUTH_DATA to be used for FILS Jouni Malinen
2016-10-26 5:30 ` Johannes Berg
2016-10-26 15:36 ` Malinen, Jouni
2016-10-26 16:10 ` Johannes Berg [this message]
2016-10-25 22:42 ` [PATCH 3/8] cfg80211: Add feature flag for Fast Initial Link Setup (FILS) Jouni Malinen
2016-10-25 22:42 ` [PATCH 4/8] cfg80211: Add Fast Initial Link Setup (FILS) auth algs Jouni Malinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1477498212.5563.2.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=jouni@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.