From mboxrd@z Thu Jan 1 00:00:00 1970 From: jbrunet@baylibre.com (Jerome Brunet) Date: Thu, 27 Oct 2016 11:40:44 +0200 Subject: [PATCH v2 2/9] dt-bindings: interrupt-controller: add DT binding for meson GPIO interrupt controller In-Reply-To: <20161027093205.GA27135@leverpostej> References: <1476890480-8884-1-git-send-email-jbrunet@baylibre.com> <1476890480-8884-3-git-send-email-jbrunet@baylibre.com> <20161026214234.4q6wmecehqh6q32o@rob-hp-laptop> <20161027093205.GA27135@leverpostej> Message-ID: <1477561244.2482.198.camel@baylibre.com> To: linus-amlogic@lists.infradead.org List-Id: linus-amlogic.lists.infradead.org On Thu, 2016-10-27 at 10:32 +0100, Mark Rutland wrote: > On Wed, Oct 26, 2016 at 04:42:35PM -0500, Rob Herring wrote: > > > > On Wed, Oct 19, 2016 at 05:21:13PM +0200, Jerome Brunet wrote: > > > > > > > > > This commit adds the device tree bindings description for > > > Amlogic's GPIO > > > interrupt controller available on the meson8, meson8b and gxbb > > > SoC families > > > > > > Signed-off-by: Jerome Brunet > > > --- > > > Rob, I did not include the Ack you gave for the RFC as bindings > > > have slightly > > > changed. Only the interrupt property has be removed following a > > > discussion I > > > had with Marc > > > > As Mark R already said, you should keep the interrupts property. > > To be clear, the interrupt routing should be described *somehow*, > though > I don't think the generic interrupts property is correct, as this is > an > interrupt *router*, i.e. this device doesn't own the interrupt, it > just > joins two parts of the line together (and so flags are meaningless). > > Thanks, > Mark. Indeed Mark, I already rewritten the driver taking Marc's comment into account. There will be 2 properties added to the DT: ?-?meson,upstream-interrupts : an array with the 8 gic interrupt used as output of the controller - ?meson,num-input-mux : the number of inputs (pads) available to the muxes I'm looking for solution to the "create mapping" issue we have in pinctrl (patch 4) before posting a v3. If you think these properties should be different, feel free to tell me now. Thx Jerome From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jerome Brunet Subject: Re: [PATCH v2 2/9] dt-bindings: interrupt-controller: add DT binding for meson GPIO interrupt controller Date: Thu, 27 Oct 2016 11:40:44 +0200 Message-ID: <1477561244.2482.198.camel@baylibre.com> References: <1476890480-8884-1-git-send-email-jbrunet@baylibre.com> <1476890480-8884-3-git-send-email-jbrunet@baylibre.com> <20161026214234.4q6wmecehqh6q32o@rob-hp-laptop> <20161027093205.GA27135@leverpostej> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20161027093205.GA27135@leverpostej> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Mark Rutland , Rob Herring Cc: devicetree@vger.kernel.org, Jason Cooper , Marc Zyngier , Kevin Hilman , Linus Walleij , Will Deacon , linux-kernel@vger.kernel.org, Russell King , linux-gpio@vger.kernel.org, Catalin Marinas , Carlo Caione , linux-amlogic@lists.infradead.org, Thomas Gleixner , linux-arm-kernel@lists.infradead.org List-Id: linux-gpio@vger.kernel.org T24gVGh1LCAyMDE2LTEwLTI3IGF0IDEwOjMyICswMTAwLCBNYXJrIFJ1dGxhbmQgd3JvdGU6Cj4g T24gV2VkLCBPY3QgMjYsIDIwMTYgYXQgMDQ6NDI6MzVQTSAtMDUwMCwgUm9iIEhlcnJpbmcgd3Jv dGU6Cj4gPiAKPiA+IE9uIFdlZCwgT2N0IDE5LCAyMDE2IGF0IDA1OjIxOjEzUE0gKzAyMDAsIEpl cm9tZSBCcnVuZXQgd3JvdGU6Cj4gPiA+IAo+ID4gPiAKPiA+ID4gVGhpcyBjb21taXQgYWRkcyB0 aGUgZGV2aWNlIHRyZWUgYmluZGluZ3MgZGVzY3JpcHRpb24gZm9yCj4gPiA+IEFtbG9naWMncyBH UElPCj4gPiA+IGludGVycnVwdCBjb250cm9sbGVyIGF2YWlsYWJsZSBvbiB0aGUgbWVzb244LCBt ZXNvbjhiIGFuZCBneGJiCj4gPiA+IFNvQyBmYW1pbGllcwo+ID4gPiAKPiA+ID4gU2lnbmVkLW9m Zi1ieTogSmVyb21lIEJydW5ldCA8amJydW5ldEBiYXlsaWJyZS5jb20+Cj4gPiA+IC0tLQo+ID4g PiBSb2IsIEkgZGlkIG5vdCBpbmNsdWRlIHRoZSBBY2sgeW91IGdhdmUgZm9yIHRoZSBSRkMgYXMg YmluZGluZ3MKPiA+ID4gaGF2ZSBzbGlnaHRseQo+ID4gPiBjaGFuZ2VkLiBPbmx5IHRoZSBpbnRl cnJ1cHQgcHJvcGVydHkgaGFzIGJlIHJlbW92ZWQgZm9sbG93aW5nIGEKPiA+ID4gZGlzY3Vzc2lv biBJCj4gPiA+IGhhZCB3aXRoIE1hcmMKPiA+IAo+ID4gQXMgTWFyayBSIGFscmVhZHkgc2FpZCwg eW91IHNob3VsZCBrZWVwIHRoZSBpbnRlcnJ1cHRzIHByb3BlcnR5Lgo+IAo+IFRvIGJlIGNsZWFy LCB0aGUgaW50ZXJydXB0IHJvdXRpbmcgc2hvdWxkIGJlIGRlc2NyaWJlZCAqc29tZWhvdyosCj4g dGhvdWdoCj4gSSBkb24ndCB0aGluayB0aGUgZ2VuZXJpYyBpbnRlcnJ1cHRzIHByb3BlcnR5IGlz IGNvcnJlY3QsIGFzIHRoaXMgaXMKPiBhbgo+IGludGVycnVwdCAqcm91dGVyKiwgaS5lLiB0aGlz IGRldmljZSBkb2Vzbid0IG93biB0aGUgaW50ZXJydXB0LCBpdAo+IGp1c3QKPiBqb2lucyB0d28g cGFydHMgb2YgdGhlIGxpbmUgdG9nZXRoZXIgKGFuZCBzbyBmbGFncyBhcmUgbWVhbmluZ2xlc3Mp Lgo+IAo+IFRoYW5rcywKPiBNYXJrLgoKSW5kZWVkIE1hcmssCgpJIGFscmVhZHkgcmV3cml0dGVu IHRoZSBkcml2ZXIgdGFraW5nIE1hcmMncyBjb21tZW50IGludG8gYWNjb3VudC4KVGhlcmUgd2ls bCBiZSAyIHByb3BlcnRpZXMgYWRkZWQgdG8gdGhlIERUOgrCoC3CoG1lc29uLHVwc3RyZWFtLWlu dGVycnVwdHMgOiBhbiBhcnJheSB3aXRoIHRoZSA4IGdpYyBpbnRlcnJ1cHQgdXNlZAphcyBvdXRw dXQgb2YgdGhlIGNvbnRyb2xsZXIKLSDCoG1lc29uLG51bS1pbnB1dC1tdXggOiB0aGUgbnVtYmVy IG9mIGlucHV0cyAocGFkcykgYXZhaWxhYmxlIHRvIHRoZQptdXhlcwoKSSdtIGxvb2tpbmcgZm9y IHNvbHV0aW9uIHRvIHRoZSAiY3JlYXRlIG1hcHBpbmciIGlzc3VlIHdlIGhhdmUgaW4KcGluY3Ry bCAocGF0Y2ggNCkgYmVmb3JlIHBvc3RpbmcgYSB2My4KCklmIHlvdSB0aGluayB0aGVzZSBwcm9w ZXJ0aWVzIHNob3VsZCBiZSBkaWZmZXJlbnQsIGZlZWwgZnJlZSB0byB0ZWxsIG1lCm5vdy4KClRo eApKZXJvbWUKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f CmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5m cmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xp bnV4LWFybS1rZXJuZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 From: jbrunet@baylibre.com (Jerome Brunet) Date: Thu, 27 Oct 2016 11:40:44 +0200 Subject: [PATCH v2 2/9] dt-bindings: interrupt-controller: add DT binding for meson GPIO interrupt controller In-Reply-To: <20161027093205.GA27135@leverpostej> References: <1476890480-8884-1-git-send-email-jbrunet@baylibre.com> <1476890480-8884-3-git-send-email-jbrunet@baylibre.com> <20161026214234.4q6wmecehqh6q32o@rob-hp-laptop> <20161027093205.GA27135@leverpostej> Message-ID: <1477561244.2482.198.camel@baylibre.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, 2016-10-27 at 10:32 +0100, Mark Rutland wrote: > On Wed, Oct 26, 2016 at 04:42:35PM -0500, Rob Herring wrote: > > > > On Wed, Oct 19, 2016 at 05:21:13PM +0200, Jerome Brunet wrote: > > > > > > > > > This commit adds the device tree bindings description for > > > Amlogic's GPIO > > > interrupt controller available on the meson8, meson8b and gxbb > > > SoC families > > > > > > Signed-off-by: Jerome Brunet > > > --- > > > Rob, I did not include the Ack you gave for the RFC as bindings > > > have slightly > > > changed. Only the interrupt property has be removed following a > > > discussion I > > > had with Marc > > > > As Mark R already said, you should keep the interrupts property. > > To be clear, the interrupt routing should be described *somehow*, > though > I don't think the generic interrupts property is correct, as this is > an > interrupt *router*, i.e. this device doesn't own the interrupt, it > just > joins two parts of the line together (and so flags are meaningless). > > Thanks, > Mark. Indeed Mark, I already rewritten the driver taking Marc's comment into account. There will be 2 properties added to the DT: ?-?meson,upstream-interrupts : an array with the 8 gic interrupt used as output of the controller - ?meson,num-input-mux : the number of inputs (pads) available to the muxes I'm looking for solution to the "create mapping" issue we have in pinctrl (patch 4) before posting a v3. If you think these properties should be different, feel free to tell me now. Thx Jerome From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S943207AbcJ0PBf (ORCPT ); Thu, 27 Oct 2016 11:01:35 -0400 Received: from mail-wm0-f41.google.com ([74.125.82.41]:37318 "EHLO mail-wm0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S943192AbcJ0PBc (ORCPT ); Thu, 27 Oct 2016 11:01:32 -0400 Message-ID: <1477561244.2482.198.camel@baylibre.com> Subject: Re: [PATCH v2 2/9] dt-bindings: interrupt-controller: add DT binding for meson GPIO interrupt controller From: Jerome Brunet To: Mark Rutland , Rob Herring Cc: Carlo Caione , Kevin Hilman , Thomas Gleixner , Jason Cooper , Marc Zyngier , linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Linus Walleij , Catalin Marinas , Will Deacon , Russell King Date: Thu, 27 Oct 2016 11:40:44 +0200 In-Reply-To: <20161027093205.GA27135@leverpostej> References: <1476890480-8884-1-git-send-email-jbrunet@baylibre.com> <1476890480-8884-3-git-send-email-jbrunet@baylibre.com> <20161026214234.4q6wmecehqh6q32o@rob-hp-laptop> <20161027093205.GA27135@leverpostej> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.20.5 (3.20.5-1.fc24) Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2016-10-27 at 10:32 +0100, Mark Rutland wrote: > On Wed, Oct 26, 2016 at 04:42:35PM -0500, Rob Herring wrote: > > > > On Wed, Oct 19, 2016 at 05:21:13PM +0200, Jerome Brunet wrote: > > > > > > > > > This commit adds the device tree bindings description for > > > Amlogic's GPIO > > > interrupt controller available on the meson8, meson8b and gxbb > > > SoC families > > > > > > Signed-off-by: Jerome Brunet > > > --- > > > Rob, I did not include the Ack you gave for the RFC as bindings > > > have slightly > > > changed. Only the interrupt property has be removed following a > > > discussion I > > > had with Marc > > > > As Mark R already said, you should keep the interrupts property. > > To be clear, the interrupt routing should be described *somehow*, > though > I don't think the generic interrupts property is correct, as this is > an > interrupt *router*, i.e. this device doesn't own the interrupt, it > just > joins two parts of the line together (and so flags are meaningless). > > Thanks, > Mark. Indeed Mark, I already rewritten the driver taking Marc's comment into account. There will be 2 properties added to the DT:  - meson,upstream-interrupts : an array with the 8 gic interrupt used as output of the controller -  meson,num-input-mux : the number of inputs (pads) available to the muxes I'm looking for solution to the "create mapping" issue we have in pinctrl (patch 4) before posting a v3. If you think these properties should be different, feel free to tell me now. Thx Jerome