From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39437)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1bzjSk-0006wP-22
	for qemu-devel@nongnu.org; Thu, 27 Oct 2016 08:07:19 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1bzjSg-0007a6-Tc
	for qemu-devel@nongnu.org; Thu, 27 Oct 2016 08:07:14 -0400
Received: from mx1.redhat.com ([209.132.183.28]:42618)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <kraxel@redhat.com>) id 1bzjSg-0007Zs-Nv
	for qemu-devel@nongnu.org; Thu, 27 Oct 2016 08:07:10 -0400
Message-ID: <1477569044.9075.13.camel@redhat.com>
From: Gerd Hoffmann <kraxel@redhat.com>
Date: Thu, 27 Oct 2016 13:50:44 +0200
In-Reply-To: <w51vawf9l7l.fsf@maestria.local.igalia.com>
References: <20161026152108.12364-1-berto@igalia.com>
	<w51vawf9l7l.fsf@maestria.local.igalia.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Mime-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] gtk: fix compilation warning with gtk
 3.22.2
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alberto Garcia <berto@igalia.com>
Cc: qemu-devel@nongnu.org

On Mi, 2016-10-26 at 17:35 +0200, Alberto Garcia wrote:
> On Wed 26 Oct 2016 05:21:08 PM CEST, Alberto Garcia wrote:
> > +#else
> > +        {
> > +            screen_width =3D gdk_screen_get_width(screen);
> > +            screen_height =3D gdk_screen_get_height(screen);
> > +        }
> > +#endif
>=20
> I forgot to remove these braces, they are actually not necessary, so
> whoever applies the patch can remove them if they want. I don't mind if
> we keep them for clarity, though, I'm fine either way.

Taking patch as-is, I find it more readable with the braces.

thanks,
  Gerd