diff for duplicates of <1477670569.12378.3.camel@crowfest.net> diff --git a/a/1.txt b/N1/1.txt index 300c6be..dfd2e2c 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -2,12 +2,12 @@ On Fri, 2016-10-28 at 11:42 -0400, Greg KH wrote: > On Fri, Oct 28, 2016 at 08:36:34AM -0700, Michael Zoran wrote: > > On Fri, 2016-10-28 at 11:31 -0400, Greg KH wrote: > > > On Fri, Oct 28, 2016 at 08:16:51AM -0700, Michael Zoran wrote: -> > > > The conversion to dma_map_sg left a few loose ends.??This +> > > > The conversion to dma_map_sg left a few loose ends. This > > > > change > > > > ties up those loose ends. > > > > > > > > 1. Settings the DMA mask is mandatory on 64 bit even though it -> > > > is optional on 32 bit.??Set the mask so that DMA space is +> > > > is optional on 32 bit. Set the mask so that DMA space is > > > > always > > > > in the lower 32 bit range of data on both platforms. > > > > @@ -17,7 +17,7 @@ On Fri, 2016-10-28 at 11:42 -0400, Greg KH wrote: > > > > if scatterlist debugging is enabled in the build configuration. > > > > > > > > 3. The error paths in create_pagelist were not -> > > > consistent.??Make +> > > > consistent. Make > > > > them all consistent by calling a helper function called > > > > cleanup_pagelistinfo to cleanup regardless of what state the > > > > pagelist @@ -26,7 +26,7 @@ On Fri, 2016-10-28 at 11:42 -0400, Greg KH wrote: > > > > 4. create_pagelist and free_pagelist had a very large amount of > > > > duplication in computing offsets into a single allocation of > > > > memory -> > > > in the DMA area.??Introduce a new structure called the +> > > > in the DMA area. Introduce a new structure called the > > > > pagelistinfo > > > > that is appened to the end of the allocation to store necessary > > > > information to prevent duplication of code and make cleanup on @@ -46,7 +46,7 @@ On Fri, 2016-10-28 at 11:42 -0400, Greg KH wrote: > > > > it > > > > were submitted piecemeal. > > > -> > > No, it's harder.??A patch should only do one type of thing, this +> > > No, it's harder. A patch should only do one type of thing, this > > > patch > > > has to be reviewed thinking of 4 different things all at once, > > > making @@ -54,7 +54,7 @@ On Fri, 2016-10-28 at 11:42 -0400, Greg KH wrote: > > > much more difficult to do so. > > > > > > We write patches to be read easily, and make them easy to -> > > review.??We +> > > review. We > > > don't write them in a way to be easy for the developer to create > > > :) > > > @@ -64,7 +64,7 @@ On Fri, 2016-10-28 at 11:42 -0400, Greg KH wrote: > > > > > > greg k-h > > -> > Point #1 and #2 would be very easy to seperate.???Point #3 and #4 +> > Point #1 and #2 would be very easy to seperate. Point #3 and #4 > > are > > essentually a redo of two major functions and are where most of the > > changes are. diff --git a/a/content_digest b/N1/content_digest index 80d55e6..4931888 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -2,22 +2,32 @@ "ref\020161028153124.GA29906@kroah.com\0" "ref\01477668994.12378.1.camel@crowfest.net\0" "ref\020161028154245.GA19454@kroah.com\0" - "From\0mzoran@crowfest.net (Michael Zoran)\0" - "Subject\0[PATCH] staging: vc04_services: tie up loose ends with dma_map_sg conversion\0" + "From\0Michael Zoran <mzoran@crowfest.net>\0" + "Subject\0Re: [PATCH] staging: vc04_services: tie up loose ends with dma_map_sg conversion\0" "Date\0Fri, 28 Oct 2016 09:02:49 -0700\0" - "To\0linux-arm-kernel@lists.infradead.org\0" + "To\0Greg KH <gregkh@linuxfoundation.org>\0" + "Cc\0devel@driverdev.osuosl.org" + daniels@collabora.com + swarren@wwwdotorg.org + lee@kernel.org + linux-kernel@vger.kernel.org + eric@anholt.net + noralf@tronnes.org + linux-rpi-kernel@lists.infradead.org + popcornmix@gmail.com + " linux-arm-kernel@lists.infradead.org\0" "\00:1\0" "b\0" "On Fri, 2016-10-28 at 11:42 -0400, Greg KH wrote:\n" "> On Fri, Oct 28, 2016 at 08:36:34AM -0700, Michael Zoran wrote:\n" "> > On Fri, 2016-10-28 at 11:31 -0400, Greg KH wrote:\n" "> > > On Fri, Oct 28, 2016 at 08:16:51AM -0700, Michael Zoran wrote:\n" - "> > > > The conversion to dma_map_sg left a few loose ends.??This\n" + "> > > > The conversion to dma_map_sg left a few loose ends.\302\240\302\240This\n" "> > > > change\n" "> > > > ties up those loose ends.\n" "> > > > \n" "> > > > 1. Settings the DMA mask is mandatory on 64 bit even though it\n" - "> > > > is optional on 32 bit.??Set the mask so that DMA space is\n" + "> > > > is optional on 32 bit.\302\240\302\240Set the mask so that DMA space is\n" "> > > > always\n" "> > > > in the lower 32 bit range of data on both platforms.\n" "> > > > \n" @@ -27,7 +37,7 @@ "> > > > if scatterlist debugging is enabled in the build configuration.\n" "> > > > \n" "> > > > 3. The error paths in create_pagelist were not\n" - "> > > > consistent.??Make\n" + "> > > > consistent.\302\240\302\240Make\n" "> > > > them all consistent by calling a helper function called\n" "> > > > cleanup_pagelistinfo to cleanup regardless of what state the\n" "> > > > pagelist\n" @@ -36,7 +46,7 @@ "> > > > 4. create_pagelist and free_pagelist had a very large amount of\n" "> > > > duplication in computing offsets into a single allocation of\n" "> > > > memory\n" - "> > > > in the DMA area.??Introduce a new structure called the\n" + "> > > > in the DMA area.\302\240\302\240Introduce a new structure called the\n" "> > > > pagelistinfo\n" "> > > > that is appened to the end of the allocation to store necessary\n" "> > > > information to prevent duplication of code and make cleanup on\n" @@ -56,7 +66,7 @@ "> > > > it\n" "> > > > were submitted piecemeal.\n" "> > > \n" - "> > > No, it's harder.??A patch should only do one type of thing, this\n" + "> > > No, it's harder.\302\240\302\240A patch should only do one type of thing, this\n" "> > > patch\n" "> > > has to be reviewed thinking of 4 different things all at once,\n" "> > > making\n" @@ -64,7 +74,7 @@ "> > > much more difficult to do so.\n" "> > > \n" "> > > We write patches to be read easily, and make them easy to\n" - "> > > review.??We\n" + "> > > review.\302\240\302\240We\n" "> > > don't write them in a way to be easy for the developer to create\n" "> > > :)\n" "> > > \n" @@ -74,7 +84,7 @@ "> > > \n" "> > > greg k-h\n" "> > \n" - "> > Point #1 and #2 would be very easy to seperate.???Point #3 and #4\n" + "> > Point #1 and #2 would be very easy to seperate.\302\240\302\240\302\240Point #3 and #4\n" "> > are\n" "> > essentually a redo of two major functions and are where most of the\n" "> > changes are.\n" @@ -101,4 +111,4 @@ "Eric had some complaints about the way that specific section of the\n" code is structured, so maybe a rewrite is best. -2e713ea884c4f2f10aca2ad6a128a190084c48681339a7353efc8a3fffc6f172 +64294a77077b69b631f1b7afb1f2d4f8254fc5c63dc804adde2e0e399b80a5d6
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.