From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi0-x244.google.com (mail-oi0-x244.google.com [IPv6:2607:f8b0:4003:c06::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3t6WrR04MCzDvXl for ; Mon, 31 Oct 2016 09:09:59 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b=pnGyjmP8; dkim-atps=neutral Received: by mail-oi0-x244.google.com with SMTP id i127so8937655oia.0 for ; Sun, 30 Oct 2016 15:09:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=Jdp5c4+veAfWrvg4GEbViZVEuCmmmYtDvrPnTg7J91M=; b=pnGyjmP8+ngxR2ZvX4bO6wPtMGndweytvbyP10oqCSCoUfdIPlTArp0Y2RIPpJodX7 UvaI8lb5ewtAb0OAMAww5c9ktXMGXSg7PmSaZ0PEGLwceWJbx9V2TGUjZLXlZLc196wN bmd5yZmSLB2FVoleqbjGFSCYuH0kOUNC6f67fv+gAnzI9NKODLF+Bo+lHSqIy6JKVW1d J3sjxaPAQZtfZraPtxWnCiUzYMtFz5nInQMp4aqXrNMD+io1E5CT0XVr99o/3wiL1rKQ xAeU5/VKEwL4I9Z75jXNHiQEWGpIDVyx5gZR48XGwyydxdvdtdv1mQQEe5AG7T2kdzEF tj+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=Jdp5c4+veAfWrvg4GEbViZVEuCmmmYtDvrPnTg7J91M=; b=hQWu43ZGlhyA1RiRTj4cnCw7VrPzArOcXqyBZ0MAgxWcWQjoYCTTChLN9zxvlnY+IC mPXijOUN/q6NYlQxa/BXoau70NSQ84NxBrOEudN4pklrU4RFL/IffcOd5sQ32FJP6FJ3 IF4njrrHNe0XBqSrhMdBPmVKxtLfgaeBs1Hl0HlVQ0NxCTjgYC+f7KevIZngffe0wEtc oTl51XHVRLnZypdGQcEpP4H0E1I/31ATyYXAPKROQJV3Cj9WW13EQp6xuGQEU8k1S0Cd VreFev5XEG6A8oisUpFCAWGkyoAbhEU/zPQgUkHs3mul5+Xz6hh4PSYrqb+b9FZFTMyB EtAQ== X-Gm-Message-State: ABUngvdquxmv5El6qF03gb+1BXdos9/F+sWg9BHQKjC9aujz85fOLTNh/RXCsey8VpU4cQ== X-Received: by 10.202.240.194 with SMTP id o185mr24416789oih.111.1477865397295; Sun, 30 Oct 2016 15:09:57 -0700 (PDT) Received: from Christophers-MacBook-Pro.local.com (45-20-192-79.lightspeed.austtx.sbcglobal.net. [45.20.192.79]) by smtp.gmail.com with ESMTPSA id q59sm7585484ota.20.2016.10.30.15.09.56 (version=TLS1 cipher=AES128-SHA bits=128/128); Sun, 30 Oct 2016 15:09:56 -0700 (PDT) From: christopher.lee.bostic@gmail.com To: openbmc@lists.ozlabs.org Cc: joel@jms.id.au, zahrens@us.ibm.com, xxpetri@de.ibm.com, Jeremy Kerr Subject: [PATCH linux v6 10/18] fsi: Implement slave initialisation Date: Sun, 30 Oct 2016 17:09:12 -0500 Message-Id: <1477865379-11566-11-git-send-email-christopher.lee.bostic@gmail.com> X-Mailer: git-send-email 2.7.4 (Apple Git-66) In-Reply-To: <1477865379-11566-1-git-send-email-christopher.lee.bostic@gmail.com> References: <1477865379-11566-1-git-send-email-christopher.lee.bostic@gmail.com> X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 30 Oct 2016 22:09:59 -0000 From: Jeremy Kerr Create fsi_slave devices during the master scan. Signed-off-by: Jeremy Kerr --- drivers/fsi/fsi-core.c | 51 ++++++++++++++++++++++++++++++++++++++++++++++++-- 1 file changed, 49 insertions(+), 2 deletions(-) diff --git a/drivers/fsi/fsi-core.c b/drivers/fsi/fsi-core.c index 2d22320..4282370 100644 --- a/drivers/fsi/fsi-core.c +++ b/drivers/fsi/fsi-core.c @@ -18,6 +18,7 @@ #include #include #include +#include #include "fsi-master.h" @@ -60,12 +61,58 @@ static bool check_crc4_u32(uint32_t x) } /* FSI slave support */ + +static void fsi_slave_release(struct device *dev) +{ + struct fsi_slave *slave = to_fsi_slave(dev); + + kfree(slave); +} + static int fsi_slave_init(struct fsi_master *master, int link, uint8_t slave_id) { - /* todo: initialise slave device, perform engine scan */ + struct fsi_slave *slave; + uint32_t chip_id; + int rc; + + rc = master->read(master, link, slave_id, 0, &chip_id, sizeof(chip_id)); + if (rc) { + dev_warn(master->dev, "can't read slave %02x:%02x: %d\n", + link, slave_id, rc); + return -ENODEV; + } + + chip_id = be32_to_cpu(chip_id); + if (!check_crc4_u32(chip_id)) { + dev_warn(master->dev, "slave %02x:%02x: invalid chip id CRC!\n", + link, slave_id); + return -EIO; + } + + pr_debug("fsi: found chip %08x at %02x:%02x:%02x\n", + master->idx, chip_id, link, slave_id); + + /* we can communicate with a slave; create devices and scan */ + slave = kzalloc(sizeof(*slave), GFP_KERNEL); + if (!slave) + return -ENOMEM; + + slave->master = master; + slave->id = slave_id; + slave->dev.parent = master->dev; + slave->dev.release = fsi_slave_release; + + dev_set_name(&slave->dev, "slave@%02x:%02x", link, slave_id); + rc = device_register(&slave->dev); + if (rc < 0) { + dev_warn(master->dev, "failed to create slave device: %d\n", + rc); + put_device(&slave->dev); + return rc; + } - return -ENODEV; + return rc; } /* FSI master support */ -- 1.8.2.2