From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-co1nam03on0074.outbound.protection.outlook.com ([104.47.40.74]:4992 "EHLO NAM03-CO1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S943680AbcJaPKj (ORCPT ); Mon, 31 Oct 2016 11:10:39 -0400 From: Bart Van Assche To: "loberman@redhat.com" CC: "linux-block@vger.kernel.org" , "tom.leiming@gmail.com" , "linux-rdma@vger.kernel.org" , "snitzer@redhat.com" , "hch@lst.de" , "martin.petersen@oracle.com" , "konrad.wilk@oracle.com" , "roger.pau@citrix.com" , "axboe@fb.com" , "linux-scsi@vger.kernel.org" , "linux-nvme@lists.infradead.org" , "jejb@linux.vnet.ibm.com" , "keith.busch@intel.com" , "dledford@redhat.com" Subject: Re: [PATCH v5 14/14] nvme: Use BLK_MQ_S_STOPPED instead of QUEUE_FLAG_STOPPED in blk-mq code Date: Mon, 31 Oct 2016 15:10:36 +0000 Message-ID: <1477926635.2511.1.camel@sandisk.com> References: <7460e8b2-2cfd-c0d5-7ae7-7f662d89dad3@sandisk.com> <540193784.5466628.1477921998345.JavaMail.zimbra@redhat.com> In-Reply-To: <540193784.5466628.1477921998345.JavaMail.zimbra@redhat.com> Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-block-owner@vger.kernel.org List-Id: linux-block@vger.kernel.org T24gTW9uLCAyMDE2LTEwLTMxIGF0IDA5OjUzIC0wNDAwLCBMYXVyZW5jZSBPYmVybWFuIHdyb3Rl Og0KPiBBcHBsaWVkIGFsbCAxNCBwYXRjaGVzLCBhbHNvIGNvcnJlY3RlZCB0aGUgcGFydCBvZiB0 aGUgeGVuLWJsa2Zyb250LmMgDQo+IGJsa2lmX3JlY292ZXIgcGF0Y2ggaW4gcGF0Y2h2NS01LzE0 Lg0KPiANCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvYmxvY2sveGVuLWJsa2Zyb250LmMgYi9kcml2 ZXJzL2Jsb2NrL3hlbi0NCj4gYmxrZnJvbnQuYw0KPiBpbmRleCA5OTA4NTk3Li42MGZmZjk5IDEw MDY0NA0KPiAtLS0gYS9kcml2ZXJzL2Jsb2NrL3hlbi1ibGtmcm9udC5jDQo+ICsrKyBiL2RyaXZl cnMvYmxvY2sveGVuLWJsa2Zyb250LmMNCj4gQEAgLTIwNDUsNiArMjA0NSw3IEBAIHN0YXRpYyBp bnQgYmxraWZfcmVjb3ZlcihzdHJ1Y3QgYmxrZnJvbnRfaW5mbw0KPiAqaW5mbykNCj4gwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoEJVR19PTihyZXEtPm5yX3BoeXNfc2VnbWVudHMg PiBzZWdzKTsNCj4gwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoGJsa19tcV9yZXF1 ZXVlX3JlcXVlc3QocmVxKTsNCj4gwqDCoMKgwqDCoMKgwqDCoMKgfQ0KPiArwqDCoMKgwqDCoMKg wqDCoGJsa19tcV9zdGFydF9zdG9wcGVkX2h3X3F1ZXVlcyhpbmZycSwNCj4gdHJ1ZSk7wqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCoqKiBDb3JyZWN0ZWQNCj4gwqDCoMKg wqDCoMKgwqDCoMKgYmxrX21xX2tpY2tfcmVxdWV1ZV9saXN0KGluZnJxKTsNCj4gwqANCj4gwqDC oMKgwqDCoMKgwqDCoMKgd2hpbGUgKChiaW8gPSBiaW9fbGlzdF9wb3AoJmluZmJpb19saXN0KSkg IT0gTlVMTCkgew0KDQpIZWxsbyBMYXVyZW5jZSwNCg0KU29ycnkgZm9yIHRoZSBidWlsZCBmYWls dXJlLiBUaGUgd2F5IHlvdSBjaGFuZ2VkIHhlbi1ibGtmcm9udCBpcyBpbmRlZWQNCndoYXQgSSBp bnRlbmRlZC4gQXBwYXJlbnRseSBJIGZvcmdvdCB0byBlbmFibGUgWGVuIGluIG15IGtlcm5lbCBj b25maWcNCi4uLg0KDQpCYXJ0Lg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bart.VanAssche@sandisk.com (Bart Van Assche) Date: Mon, 31 Oct 2016 15:10:36 +0000 Subject: [PATCH v5 14/14] nvme: Use BLK_MQ_S_STOPPED instead of QUEUE_FLAG_STOPPED in blk-mq code In-Reply-To: <540193784.5466628.1477921998345.JavaMail.zimbra@redhat.com> References: <7460e8b2-2cfd-c0d5-7ae7-7f662d89dad3@sandisk.com> <540193784.5466628.1477921998345.JavaMail.zimbra@redhat.com> Message-ID: <1477926635.2511.1.camel@sandisk.com> On Mon, 2016-10-31@09:53 -0400, Laurence Oberman wrote: > Applied all 14 patches, also corrected the part of the xen-blkfront.c > blkif_recover patch in patchv5-5/14. > > diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen- > blkfront.c > index 9908597..60fff99 100644 > --- a/drivers/block/xen-blkfront.c > +++ b/drivers/block/xen-blkfront.c > @@ -2045,6 +2045,7 @@ static int blkif_recover(struct blkfront_info > *info) > ?????????????????BUG_ON(req->nr_phys_segments > segs); > ?????????????????blk_mq_requeue_request(req); > ?????????} > +????????blk_mq_start_stopped_hw_queues(infrq, > true);????????????????????*** Corrected > ?????????blk_mq_kick_requeue_list(infrq); > ? > ?????????while ((bio = bio_list_pop(&infbio_list)) != NULL) { Hello Laurence, Sorry for the build failure. The way you changed xen-blkfront is indeed what I intended. Apparently I forgot to enable Xen in my kernel config ... Bart. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bart Van Assche Subject: Re: [PATCH v5 14/14] nvme: Use BLK_MQ_S_STOPPED instead of QUEUE_FLAG_STOPPED in blk-mq code Date: Mon, 31 Oct 2016 15:10:36 +0000 Message-ID: <1477926635.2511.1.camel@sandisk.com> References: <7460e8b2-2cfd-c0d5-7ae7-7f662d89dad3@sandisk.com> <540193784.5466628.1477921998345.JavaMail.zimbra@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <540193784.5466628.1477921998345.JavaMail.zimbra@redhat.com> Content-Language: en-US Content-ID: <77BA6145B5B13840AAB2DC0AD60AE64A@namprd02.prod.outlook.com> Sender: linux-scsi-owner@vger.kernel.org To: "loberman@redhat.com" Cc: "linux-block@vger.kernel.org" , "tom.leiming@gmail.com" , "linux-rdma@vger.kernel.org" , "snitzer@redhat.com" , "hch@lst.de" , "martin.petersen@oracle.com" , "konrad.wilk@oracle.com" , "roger.pau@citrix.com" , "axboe@fb.com" , "linux-scsi@vger.kernel.org" , "linux-nvme@lists.infradead.org" , "jejb@linux.vnet.ibm.com" , "keith.busch@intel.com" , "dledford@redhat.com" List-Id: linux-rdma@vger.kernel.org T24gTW9uLCAyMDE2LTEwLTMxIGF0IDA5OjUzIC0wNDAwLCBMYXVyZW5jZSBPYmVybWFuIHdyb3Rl Og0KPiBBcHBsaWVkIGFsbCAxNCBwYXRjaGVzLCBhbHNvIGNvcnJlY3RlZCB0aGUgcGFydCBvZiB0 aGUgeGVuLWJsa2Zyb250LmMgDQo+IGJsa2lmX3JlY292ZXIgcGF0Y2ggaW4gcGF0Y2h2NS01LzE0 Lg0KPiANCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvYmxvY2sveGVuLWJsa2Zyb250LmMgYi9kcml2 ZXJzL2Jsb2NrL3hlbi0NCj4gYmxrZnJvbnQuYw0KPiBpbmRleCA5OTA4NTk3Li42MGZmZjk5IDEw MDY0NA0KPiAtLS0gYS9kcml2ZXJzL2Jsb2NrL3hlbi1ibGtmcm9udC5jDQo+ICsrKyBiL2RyaXZl cnMvYmxvY2sveGVuLWJsa2Zyb250LmMNCj4gQEAgLTIwNDUsNiArMjA0NSw3IEBAIHN0YXRpYyBp bnQgYmxraWZfcmVjb3ZlcihzdHJ1Y3QgYmxrZnJvbnRfaW5mbw0KPiAqaW5mbykNCj4gwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoEJVR19PTihyZXEtPm5yX3BoeXNfc2VnbWVudHMg PiBzZWdzKTsNCj4gwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoGJsa19tcV9yZXF1 ZXVlX3JlcXVlc3QocmVxKTsNCj4gwqDCoMKgwqDCoMKgwqDCoMKgfQ0KPiArwqDCoMKgwqDCoMKg wqDCoGJsa19tcV9zdGFydF9zdG9wcGVkX2h3X3F1ZXVlcyhpbmZycSwNCj4gdHJ1ZSk7wqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCoqKiBDb3JyZWN0ZWQNCj4gwqDCoMKg wqDCoMKgwqDCoMKgYmxrX21xX2tpY2tfcmVxdWV1ZV9saXN0KGluZnJxKTsNCj4gwqANCj4gwqDC oMKgwqDCoMKgwqDCoMKgd2hpbGUgKChiaW8gPSBiaW9fbGlzdF9wb3AoJmluZmJpb19saXN0KSkg IT0gTlVMTCkgew0KDQpIZWxsbyBMYXVyZW5jZSwNCg0KU29ycnkgZm9yIHRoZSBidWlsZCBmYWls dXJlLiBUaGUgd2F5IHlvdSBjaGFuZ2VkIHhlbi1ibGtmcm9udCBpcyBpbmRlZWQNCndoYXQgSSBp bnRlbmRlZC4gQXBwYXJlbnRseSBJIGZvcmdvdCB0byBlbmFibGUgWGVuIGluIG15IGtlcm5lbCBj b25maWcNCi4uLg0KDQpCYXJ0Lg==