All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: Samuel Thibault <samuel.thibault@ens-lyon.org>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/4] console: add API to get underlying gui window ID
Date: Tue, 01 Nov 2016 11:11:32 +0100	[thread overview]
Message-ID: <1477995092.26731.28.camel@redhat.com> (raw)
In-Reply-To: <20161031160007.6047-2-samuel.thibault@ens-lyon.org>

>  int qemu_console_get_width(QemuConsole *con, int fallback);
>  int qemu_console_get_height(QemuConsole *con, int fallback);
> +/* Return the low-level window id for the first graphical console */
> +int qemu_graphic_console_get_window_id(void);
> +void qemu_console_set_window_id(int index, int window_id);

Both qemu_console_{set,get}_window_id should have a QemuConsole *con
argument, like the other ones.

There is also no reason to limit this interface to graphic consoles.
baum.c can use qemu_console_lookup_by_index() and
qemu_console_is_graphic() to implement this logic (sorry, missed this on
the first review).

cheers,
  Gerd

  reply	other threads:[~2016-11-01 10:11 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-31 16:00 [Qemu-devel] [PATCHv3 0/4] Move getting XWindow ID from baum driver to graphical backend Samuel Thibault
2016-10-31 16:00 ` [Qemu-devel] [PATCH 1/4] console: add API to get underlying gui window ID Samuel Thibault
2016-11-01 10:11   ` Gerd Hoffmann [this message]
2016-10-31 16:00 ` [Qemu-devel] [PATCH 2/4] console: move window ID code from baum to sdl Samuel Thibault
2016-10-31 16:00 ` [Qemu-devel] [PATCH 3/4] sdl2: set window ID Samuel Thibault
2016-10-31 16:00 ` [Qemu-devel] [PATCH 4/4] gtk: " Samuel Thibault
2016-10-31 16:01   ` Samuel Thibault
2016-10-31 16:59   ` Daniel P. Berrange

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1477995092.26731.28.camel@redhat.com \
    --to=kraxel@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=samuel.thibault@ens-lyon.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.