All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Improve lockdep tracking for obj->mm.lock
Date: Tue, 01 Nov 2016 14:18:16 +0200	[thread overview]
Message-ID: <1478002696.3103.10.camel@linux.intel.com> (raw)
In-Reply-To: <20161101121134.27504-1-chris@chris-wilson.co.uk>

On ti, 2016-11-01 at 12:11 +0000, Chris Wilson wrote:
> The shrinker may appear to recurse into obj->mm.lock as the shrinker may
> be called from a direct reclaim path whilst handling get_pages. We
> filter out recursing on the same obj->mm.lock by inspecting
> obj->mm.pages, but we do want to take the lock on a second object in
> order to reap their pages. lockdep spots the recursion on the same
> lockclass and needs annotation to avoid a false positive. To keep the
> two paths distinct, create an enum to indicate which subclass of
> obj->mm.lock. This removes the false positive and avoids masking real
> bugs.
> 
> Suggested-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>

Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>

Regards, Joonas
-- 
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2016-11-01 12:18 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-01 12:11 [PATCH] drm/i915: Improve lockdep tracking for obj->mm.lock Chris Wilson
2016-11-01 12:18 ` Joonas Lahtinen [this message]
2016-11-01 13:16 ` ✗ Fi.CI.BAT: warning for " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1478002696.3103.10.camel@linux.intel.com \
    --to=joonas.lahtinen@linux.intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.