Re: [PATCH linux] ARM: dts: aspeed-g5: Update zaius with new spi-nor binding

[Andrew Jeffery <andrew@aj.id.au>]

[-- Attachment #1: Type: text/plain, Size: 1319 bytes --]

On Wed, 2016-11-02 at 10:15 +1030, Joel Stanley wrote:
> Hey Xo,
> 
> On Wed, Nov 2, 2016 at 10:00 AM, Xo Wang <xow@google.com> wrote:
> 
> > 
> > +&spi1 {
> > +       status = "okay";
> > +       pinctrl-names = "default";
> > +       pinctrl-0 = <&pinctrl_spi1_default>;
> > +
> > +       flash@0 {
> > +               status = "okay";
> > +               label = "pnor";
> > +       };
> > +};
> > +
> > +&spi2 {
> > +       status = "okay";
> I think we want to request the pins here. Something like this:
> 
> +
> +         pinctrl-names = "default";
> +         pinctrl-0 = <&pinctrl_spi2ck_default
> +                         &pinctrl_spi2cs0_default
> +                         &pinctrl_spi2cs1_default
> +                         &pinctrl_spi2miso_default
> +                         &pinctrl_spi2mosi_default>;

Yes, we need this, though maybe the chip selects should be pushed out
to the board dts?

Andrew

> +
> 
> Can you try that and do a test boot on your hardware?
> 
> Cheers,
> 
> Joel
> 
> > 
> > +       flash@0 {
> > +               status = "okay";
> > +       };
> > +};
> > +

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]