From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
To: Zhenyu Wang <zhenyuw@linux.intel.com>, igvt-g-dev@lists.01.org
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915/gvt: Fix workload status after wait
Date: Wed, 02 Nov 2016 08:47:52 +0200 [thread overview]
Message-ID: <1478069272.2993.1.camel@linux.intel.com> (raw)
In-Reply-To: <20161102054137.25612-1-zhenyuw@linux.intel.com>
On ke, 2016-11-02 at 13:41 +0800, Zhenyu Wang wrote:
> From commit e95433c73a11759203af1cae5958f998c9673370, workload status setting
> was changed to only capture on error path, but we need to set it properly in
> normal path too, otherwise we'll fail to complete workload which could lead
> guest VM vGPU reset.
>
Should have Fixes tag with the above commit.
> @@ -455,7 +455,8 @@ static int workload_thread(void *priv)
> if (lret < 0) {
> workload->status = lret;
> gvt_err("fail to wait workload, skip\n");
> - }
> + } else
> + workload->status = 0;
All branches of if-else continuum must use braces if one does, so
"} else {" here
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-11-02 6:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-02 5:41 [PATCH] drm/i915/gvt: Fix workload status after wait Zhenyu Wang
2016-11-02 6:24 ` ✗ Fi.CI.BAT: failure for " Patchwork
2016-11-02 7:08 ` Saarinen, Jani
2016-11-02 6:47 ` Joonas Lahtinen [this message]
2016-11-02 7:07 ` [PATCH] " Zhenyu Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1478069272.2993.1.camel@linux.intel.com \
--to=joonas.lahtinen@linux.intel.com \
--cc=igvt-g-dev@lists.01.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=zhenyuw@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.